[1/n] Move my node ID to metadata and metadata-manager related fixes #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedSoliman
changed the title
AhmedSoliman
force-pushed
the
pr1240
branch
2 times, most recently
from
b9848c4
to
b235d07
Compare
This was referenced Feb 28, 2024
AhmedSoliman
force-pushed
the
pr1240
branch
3 times, most recently
from
cede892
to
4eae592
Compare
Removes `NodeId::my_node_id()` and introduces `metadata().my_node_id()`. Along with various fixes to allow automatic propagation of metadata between tasks
tillrohrmann
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Really good work @AhmedSoliman. The changes look good to me. +1 for merging.
| @@ -132,6 +142,11 @@ impl MetadataWriter { | |||
| } | |||
| } | |||
|
|
|||
| /// Should be called once on node startup. Updates are ignored after the initial value is set. | |||
| pub fn set_my_node_id(&self, id: GenerationalNodeId) { | |||
| let _ = self.inner.my_node_id.set(id); | |||
There was a problem hiding this comment.
Should we add an expect to catch accidental misuses?
|
Manually merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1/n] Move my node ID to metadata and metadata-manager related fixes
Removes
NodeId::my_node_id()and introducesmetadata().my_node_id(). Along with various fixes to allow automatic propagation of metadata between tasksStack created with Sapling. Best reviewed with ReviewStack.