[3/n] Stub networking and network sender #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2024
This was referenced Feb 29, 2024
AhmedSoliman
force-pushed
the
pr1243
branch
3 times, most recently
from
784b0bf
to
be88dde
Compare
tillrohrmann
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Good work @AhmedSoliman. The network is manifesting more and more in front of my eyes :-) LGTM. +1 for merging.
This was referenced Mar 4, 2024
tillrohrmann
approved these changes
Mar 4, 2024
This also introduces metadata manager's machinery for sending metadata updates and accepting metadata fetch requests across nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[3/n] Stub networking and network sender
This also introduces metadata manager's machinery for sending metadata updates and accepting metadata fetch requests across nodes
Stack created with Sapling. Best reviewed with ReviewStack.