Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2/n] Bifrost provider configuration improvements pt1 #1322

Merged
merged 3 commits into from
Mar 27, 2024
Merged

[2/n] Bifrost provider configuration improvements pt1 #1322

merged 3 commits into from
Mar 27, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Mar 26, 2024 •
edited
Loading

[2/n] Bifrost provider configuration improvements pt1

  • Rename and flattening of bifrost provider kinds and configurations
  • Provider configuration is typed (no more lazy config parsing errors)
  • Dedicated error type for provider errors

Stack created with Sapling. Best reviewed with ReviewStack.

This was referenced Mar 26, 2024
Merged
Merged
@AhmedSoliman AhmedSoliman marked this pull request as ready for review March 26, 2024 14:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

Test Results

 92 files  ±0   92 suites  ±0   10m 22s ⏱️ -1s
 77 tests  - 2   73 ✅  - 4  2 💤 ±0  2 ❌ +2 
201 runs   - 4  191 ✅  - 8  6 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 60c457a. ± Comparison against base commit 21a407f.

This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both. 
dev.restate.e2e.JavaKafkaIngressTest ‑ handleEventInCounterService(URL, int, IngressClient)
dev.restate.e2e.JavaKafkaIngressTest ‑ handleEventInEventHandler(URL, int, IngressClient)
dev.restate.e2e.NodeKafkaIngressTest ‑ handleEventInCounterService(URL, int, IngressClient)
dev.restate.e2e.NodeKafkaIngressTest ‑ handleEventInEventHandler(URL, int, IngressClient)

dev.restate.e2e.JavaKafkaIngressTest ‑ initializationError
dev.restate.e2e.NodeKafkaIngressTest ‑ initializationError

♻️ This comment has been updated with latest results.

@AhmedSoliman
Enables toml configs
1a47f34 
- Use file_exact because file searches parent directories automatically for the config, definitely not the behaviour we want.
- If config file was not found, it silently ignored the supplied --config-file argument, this was fixed
- Support loading toml files
- Makes it clear in logs when we are starting with the built-in default config.
@AhmedSoliman AhmedSoliman mentioned this pull request Mar 27, 2024
Merged
@AhmedSoliman
[1/n] Use snake_case for all configuration enums
6f13480
@AhmedSoliman
[2/n] Bifrost provider configuration improvements pt1
60c457a 
- Rename and flattening of bifrost provider kinds and configurations
- Provider configuration is typed (no more lazy config parsing errors)
- Dedicated error type for provider errors
@AhmedSoliman AhmedSoliman changed the title Bifrost provider configuration improvements pt1 [2/n] Bifrost provider configuration improvements pt1 Mar 27, 2024
tillrohrmann
tillrohrmann approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging :-)

This was referenced Mar 27, 2024
Closed
Merged
@AhmedSoliman AhmedSoliman merged commit 60c457a into main Mar 27, 2024
8 of 11 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1322 branch March 27, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @tillrohrmann