-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4/n] Partial refactor of worker and admin role configs #1328
Conversation
b2fb909
to
dd47f77
Compare
Test Results 92 files ±0 92 suites ±0 10m 20s ⏱️ -5s For more details on these failures, see this check. Results for commit dd47f77. ± Comparison against base commit 1a47f34. This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With every commit our configuration story becomes a bit nicer. Well done :-) +1 for merging.
crates/node/src/options.rs
Outdated
|
||
/// todo: remove. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think admin_address
is no longer used. So feel free to just remove it.
@@ -46,6 +46,14 @@ impl ServiceClient { | |||
pub(crate) fn new(http: HttpClient, lambda: LambdaClient) -> Self { | |||
Self { http, lambda } | |||
} | |||
|
|||
pub fn from_options(options: Options, assume_role_cache_mode: AssumeRoleCacheMode) -> Self { | |||
let (http, lambda) = options.dissolve(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, learned again something :-)
More re-org and cleanup. We need to move away from the `Options::build()` style: - We should treat configuration as data-only structures that won't be consumed on service creation - We pave the way for updateable config, components will own a "projection" to the config in the future instead of consuming it on startup This is not the final structure, many changes are transitional
[4/n] Partial refactor of worker and admin role configs
More re-org and cleanup. We need to move away from the
Options::build()
style:This is not the final structure, many changes are transitional