more on worker config #1333
Closed
more on worker config #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More re-org and cleanup. We need to move away from the `Options::build()` style: - We should treat configuration as data-only structures that won't be consumed on service creation - We pave the way for updateable config, components will own a "projection" to the config in the future instead of consuming it on startup This is not the final structure, many changes are transitional
This was referenced Mar 27, 2024
Test Results 92 files ±0 92 suites ±0 10m 34s ⏱️ +4s For more details on these failures, see this check. Results for commit 48c40fa. ± Comparison against base commit 7553ccc. This pull request removes 8 and adds 2 tests. Note that renamed tests count towards both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more on worker config
Stack created with Sapling. Best reviewed with ReviewStack.