InvocationStatus::Inboxed #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
proposal-invocation-status-inboxed
branch
from
5c18189
to
2742f7c
Compare
slinkydeveloper
force-pushed
the
proposal-invocation-status-inboxed
branch
3 times, most recently
from
55fe2e6
to
cb1bcd8
Compare
slinkydeveloper
changed the title
slinkydeveloper
changed the title
This was referenced Apr 2, 2024
Closed
slinkydeveloper
force-pushed
the
proposal-invocation-status-inboxed
branch
from
cb1bcd8
to
2c2adb5
Compare
tillrohrmann
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. The changes look good to me :-) +1 for merging.
| @@ -48,11 +53,11 @@ impl SequenceNumberInboxEntry { | |||
| } | |||
| pub fn from_invocation( | |||
There was a problem hiding this comment.
maybe rename into invocation?
There was a problem hiding this comment.
I prefer from_invocation to stay consistent with below method from_state_mutation.
Comment on lines
-52
to
-72
| match caller { | ||
| Source::Service(caller) => { | ||
| row.invoked_by("component"); | ||
| row.invoked_by_component(&caller.service_id.service_name); | ||
| if row.is_invoked_by_id_defined() { | ||
| row.invoked_by_id(format_using(output, &caller)); | ||
| } | ||
| } | ||
| Source::Ingress => { | ||
| row.invoked_by("ingress"); | ||
| } | ||
| Source::Internal => { | ||
| row.invoked_by("restate"); | ||
| } | ||
| } | ||
| if row.is_trace_id_defined() { | ||
| let tid = span_context.trace_id(); | ||
| if tid != TraceId::INVALID { | ||
| row.trace_id(format_using(output, &tid)); | ||
| } | ||
| } |
There was a problem hiding this comment.
How will removing these columns affect the CLI?
There was a problem hiding this comment.
The CLI won't need to query the sys_inbox table anymore now. I defer those changes to followups.
crates/worker/src/partition/state_machine/command_interpreter/mod.rs
Outdated
Show resolved
Hide resolved
crates/worker/src/partition/state_machine/effect_interpreter.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+421
to
+422
| let inboxed_status = | ||
| state_storage.get_invocation_status(&invocation_id).await?; |
There was a problem hiding this comment.
I guess this is one of the additional reads we are introducing by having the InvocationStatus::Inboxed.
There was a problem hiding this comment.
this is the only one i think
Don't store the ServiceInvocation anymore in the inbox entry.
slinkydeveloper
force-pushed
the
proposal-invocation-status-inboxed
branch
from
727a7d6
to
40e9dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the metadata about the inboxed invocation in the invocation status table.
This simplifies a bunch of problems, such as terminating inboxed invocations and the upcoming issue of inboxed idempoten invocations (described in #1326)