Sync nodes configuration if node from the future connects #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
issues/1696
branch
2 times, most recently
from
656dd0a
to
b2205f5
Compare
AhmedSoliman
approved these changes
Jul 17, 2024
| nodes_config = self.metadata.nodes_config_ref(); | ||
|
|
||
| if let Err(e) = nodes_config.find_node_by_id(peer_node_id) { | ||
| info!("Could not find remote node {} after syncing nodes configuration. Local version '{}', remote version '{:?}'.", peer_node_id, nodes_config.version(), header.my_nodes_config_version.expect("must be present")); |
There was a problem hiding this comment.
Perhaps a warn instead?
tillrohrmann
force-pushed
the
issues/1696
branch
from
b2205f5
to
d157c82
Compare
This commit introduces the ControlProcessors command which allows an external entity to instruct the PartitionProcessorManager to start and stop PartitionProcessors. This fixes restatedev#1695.
This commit makes the server sync the nodes configuration if a remote node from the future tries to connect to it. This fixes restatedev#1696.
tillrohrmann
force-pushed
the
issues/1696
branch
from
d157c82
to
2e1e0a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the server sync the nodes configuration if a remote
node from the future tries to connect to it.
This fixes #1696.
This PR is based on #1698.