[Bifrost] Decouple loglet errors from bifrost errors #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 8, 2024
AhmedSoliman
force-pushed
the
pr1705
branch
3 times, most recently
from
95a7a6a
to
c500801
Compare
This was referenced Jul 17, 2024
This was referenced Jul 18, 2024
tillrohrmann
approved these changes
Jul 18, 2024
crates/bifrost/src/loglet/error.rs
Outdated
|
|
||
| /// Represents a type-erased error from the loglet provider. | ||
| pub trait LogletError: std::error::Error + Send + Sync + Debug + Display + 'static { | ||
| /// Signal upper layers whether this erorr should be retried or not. |
AhmedSoliman
force-pushed
the
pr1705
branch
3 times, most recently
from
7e8dc57
to
0d078d3
Compare
A restructure the allows finer-grain control over what types loglet providers have access to. This will be exploited more in upcoming PRs.
- Major cleanup of loglet error handling, this removes the unnecessary leakage of internal loglet error types to bifrost. - No more superflous `Arc<>` of non-Clone errors. - FindTail on loglets cannot return Sealed error (enforcement via type-system)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bifrost] Decouple loglet errors from bifrost errors
Arc<>of non-Clone errors.Stack created with Sapling. Best reviewed with ReviewStack.