[Bifrost] rename bifrost read functions #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2024
AhmedSoliman
force-pushed
the
pr1722
branch
4 times, most recently
from
4027a19
to
01d336a
Compare
tillrohrmann
approved these changes
Jul 22, 2024
| from: Lsn, | ||
| ) -> Result<Option<LogRecord>> { | ||
| self.inner.read_next_single_opt(log_id, from).await | ||
| pub async fn read_opt(&self, log_id: LogId, from: Lsn) -> Result<Option<LogRecord>> { |
There was a problem hiding this comment.
Are we going to remove this method as stated in the commit message?
There was a problem hiding this comment.
The next commit answers this question. Yes this method will get removed.
A restructure the allows finer-grain control over what types loglet providers have access to. This will be exploited more in upcoming PRs.
- Major cleanup of loglet error handling, this removes the unnecessary leakage of internal loglet error types to bifrost. - No more superflous `Arc<>` of non-Clone errors. - FindTail on loglets cannot return Sealed error (enforcement via type-system)
This also adds an optional limit to loglet readstreams to enable creating a readstream with a pre-determined end offset.
In preparation to allow multi-segment chains, local loglets in single-node bootstrap now get unique random ids.
In preparation for the bifrost read_opt to be removed and replaced with `read()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bifrost] rename bifrost read functions
In preparation for the bifrost read_opt to be removed and replaced with
read()Stack created with Sapling. Best reviewed with ReviewStack.