Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bifrost] Loglet read stream with known tail lsn #1742

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[Bifrost] Loglet read stream with known tail lsn #1742

merged 1 commit into from
Jul 26, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Jul 24, 2024 •
edited
Loading

@AhmedSoliman AhmedSoliman mentioned this pull request Jul 24, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

Test Results

102 files  ±0  102 suites  ±0   22m 51s ⏱️ -31s
 84 tests ±0   84 ✅ ±0  0 💤 ±0  0 ❌ ±0 
217 runs  ±0  217 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7df7c99. ± Comparison against base commit 357c317.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman mentioned this pull request Jul 24, 2024
Merged
@AhmedSoliman AhmedSoliman changed the title Loglet read stream with known tail lsn [Bifrost] Loglet read stream with known tail lsn Jul 24, 2024
@AhmedSoliman AhmedSoliman marked this pull request as ready for review July 24, 2024 10:24
This was referenced Jul 24, 2024
Merged
Merged
tillrohrmann
tillrohrmann approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

@AhmedSoliman AhmedSoliman force-pushed the pr1742 branch 2 times, most recently from 7b15172 to e2736c9 Compare July 25, 2024 16:22
@AhmedSoliman AhmedSoliman mentioned this pull request Jul 25, 2024
Merged
@AhmedSoliman
[Bifrost] Loglet read stream with known tail lsn
7df7c99 
Loglet wrapper now limits reads if the loglet sealed tail is known
@AhmedSoliman AhmedSoliman merged commit 7df7c99 into main Jul 26, 2024
9 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1742 branch July 26, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @tillrohrmann