[Bifrost] Watch tail updates #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2024
tillrohrmann
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Nice work @AhmedSoliman :-) LGTM. +1 for merging. My comment about pin-project is unrelated.
crates/bifrost/src/loglet/util.rs
Outdated
| } | ||
|
|
||
| /// Blocks until the offset is greater or equal to the given offset. | ||
| /// Blocks until the tail is beyong the given offset. |
Comment on lines
43
to
48
| #[pin] | ||
| iterator: DBRawIteratorWithThreadMode<'static, DB>, | ||
| #[pin] | ||
| release_watch: WatchStream<LogletOffset>, | ||
| tail_watch: BoxStream<'static, TailState<LogletOffset>>, | ||
| #[pin] | ||
| terminated: bool, |
There was a problem hiding this comment.
I think that these fields no longer need to be pinned. That way we could get completely rid of pin_project for this type.
There was a problem hiding this comment.
I'll do that in a follow up PR.
| @@ -179,9 +183,9 @@ struct MemoryReadStream { | |||
| /// The next offset to read from | |||
| read_pointer: LogletOffset, | |||
| #[pin] | |||
There was a problem hiding this comment.
I think there is no need for the pin projections here.
There was a problem hiding this comment.
Will do that in a follow up PR on top of the stack
Loglet wrapper now limits reads if the loglet sealed tail is known
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bifrost] Watch tail updates
Stack created with Sapling. Best reviewed with ReviewStack.