Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bifrost] Move Record to restate-types #1929

Merged
merged 3 commits into from
Sep 9, 2024
Merged

[Bifrost] Move Record to restate-types #1929

merged 3 commits into from
Sep 9, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Sep 5, 2024

[Bifrost] Move Record to restate-types

Another mechanical change to make this type available to log-server in future PRs


Stack created with Sapling. Best reviewed with ReviewStack.

Copy link

github-actions bot commented Sep 5, 2024

Test Results

15 files  ±0  15 suites  ±0   19m 42s ⏱️ +11s
 6 tests ±0   6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
18 runs  ±0  18 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 02d825c. ± Comparison against base commit 81d73da.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Allows Outgoing<M> values to be sent directly if they were reciprocal to Incoming.
Another mechanical change to make this type available to log-server in future PRs
@AhmedSoliman AhmedSoliman merged commit f6da847 into main Sep 9, 2024
4 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1929 branch September 9, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants