Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements avrt #324

Closed
wants to merge 6 commits into from
Closed

implements avrt #324

wants to merge 6 commits into from

Conversation

k-brac
Copy link
Contributor

@k-brac k-brac commented Aug 23, 2016

Implements avrt
Adds a macro for enum having negative values

@retep998
Copy link
Owner

With the -gnu targets Rust is able to work standalone without a separate C/C++ toolchain. This means that the only import libraries which are available are either those that Rust bundles, or winapi bundles. In the case of avrt, Rust does not bundle it, therefore winapi must bundle libavrt.a itself. The current way of resolving this is getting libavrt.a from a mingw-w64 installation and putting it in the correct location. See https://github.com/retep998/winapi-rs/tree/master/lib/secur32 for an example of this. However in the near future I will likely be solving this with #302 instead.

AVRT_PRIORITY_CRITICAL,
}}

ENUM!{enum AVRT_NOTIFICATION {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strangely enough, AVRT_NOTIFICATION was actually removed in the Windows 10 SDK. Since I try to track the latest Windows 10 SDK with winapi, I'd rather this not be here, unless you can provide a compelling reason for why it should be kept.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. My visual studio was not properly setup to use the latest sdk... Hence I removed AVRT_NOTIFICATION
The rest doesn't seem to have been modified

@retep998
Copy link
Owner

This PR will need to be updated for the winapi 0.3 new world order. #316

@retep998 retep998 changed the base branch from master to dev November 28, 2016 16:14
@k-brac
Copy link
Contributor Author

k-brac commented Jan 17, 2017

merged in #348

@k-brac k-brac closed this Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants