implement avrt with regard to #316 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retep998
requested changes
Dec 16, 2016
| extern crate winapi; | ||
| use winapi::*; | ||
|
|
||
| extern "system" { |
There was a problem hiding this comment.
These functions really should be defined in src/um/avrt.rs.
| use um::winnt::LONGLONG; | ||
|
|
||
| ENUM_NEG!{enum AVRT_PRIORITY { | ||
| AVRT_PRIORITY_VERYLOW = -2, |
There was a problem hiding this comment.
I'd rather this be written as -2i32 as u32 and just using ENUM! instead of creating a new macro.
retep998
requested changes
Dec 19, 2016
|
|
||
| pub const THREAD_ORDER_GROUP_INFINITE_TIMEOUT: LONGLONG = -1; | ||
|
|
||
| FN!(stdcall AvSetMmThreadCharacteristicsA(TaskName: LPCSTR, |
There was a problem hiding this comment.
FN! is the wrong macro to use. You should be using EXTERN! here. Also the indentation is wrong.
https://github.com/retep998/winapi-rs/blob/dev/CONTRIBUTING.md#functions
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am creating a new pull request in order to conform avrt to #316 (hopefully)