Skip to content

Commit

Permalink
Add David as approver
Browse files Browse the repository at this point in the history
David meets all criteria for an approver:

- [x] Reviewer for at least 3 months
- [x] Primary reviewer for at least 10 substantial PRs to the codebase, e.g.
  * knative#1246
  * knative#1194
  * knative#738
  * knative#832
  * knative#1016
  * knative#877
  * knative#667
  * knative#697
  * knative#1212
  * knative#835
- [x] Reviewed at least 30 PRs to the codebase ([38 assigned PRs](https://github.com/knative/client/pulls?q=type%3Apr+assignee%3Adsimansk+))
- [x] Nominated by a WG lead (rhuss)

Congrats David ! Thanks a lot for your awesome work & contributions.
  • Loading branch information
rhuss committed Mar 9, 2021
1 parent ead3344 commit f266fca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion OWNERS
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
approvers:
- maximilien
- dsimansk
- client-wg-leads
- toc
reviewers:
- itsmurugappan
- dsimansk

0 comments on commit f266fca

Please sign in to comment.