Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The franka_gazebo gripperAction action Service implementation should be improved #33

Open
1 of 2 tasks
rickstaa opened this issue Nov 26, 2021 · 5 comments
Open
1 of 2 tasks
Assignees
Labels
bug Something isn't working upstream Problems caused by upstream issues.

Comments

@rickstaa
Copy link
Owner

rickstaa commented Nov 26, 2021

The simulated gripper is implemented suboptimal in franka_ros (see frankaemika/franka_ros#172):

  1. Gripper PID gains need improvement for the /franka_gripper/gripper_action/goal action to set the gripper width accurately when the gripper is vertical (see this and this comment).
  2. Additionally, there is a need to enhance the functionality of the /franka_gripper/gripper_action/goal action. The gripperAction currently has a limitation—it can only grasp objects when the gripper width is explicitly specified. On the other hand, the grasp action can grasp things but cannot set a desired gripper width. In reinforcement learning, it would be advantageous for the robot to autonomously learn and set the gripper width while grasping objects, even without prior knowledge of the object size.

EDIT: I worked around issue two by setting the /franka_gripper/gripper_action/width_tolerance parameter to a value more significant than the max gripper width (see https://frankaemika.github.io/docs/franka_ros.html#frankagrippersim).

TODOs

  • Provide a way to grasp objects.
  • Tune the gripper PID gains.
@rickstaa rickstaa added the bug Something isn't working label Nov 26, 2021
@rickstaa
Copy link
Owner Author

Fixed when frankaemika/franka_ros#172 is fixed.

@rickstaa rickstaa changed the title The franka_gazebo gripper action currently doesn work The franka_gazebo gripper action currently doesn't work Jan 24, 2022
@hamsadatta
Copy link

Hi @rickstaa ,
I am trying to manually grasp the object using moveit. But I see the below behavior (check the animation). The gripper's finger moves back once it detects an object. How to disable that feedback behavior. I also tried to set the "brute_force_grasping" argument to true but did it not bring any change. My "control_type" is set to "trajectory".

panda_grasp.mp4

@rickstaa
Copy link
Owner Author

Hi @rickstaa , I am trying to manually grasp the object using moveit. But I see the below behavior (check the animation). The gripper's finger moves back once it detects an object. How to disable that feedback behavior. I also tried to set the "brute_force_grasping" argument to true but did it not bring any change. My "control_type" is set to "trajectory".

panda_grasp.mp4

@hamsadatta thanks for your bug report. I also need to fix this for my own research so I will take a look this week 👍🏻. I got it to work earlier.

@rickstaa
Copy link
Owner Author

rickstaa commented Nov 20, 2023

@hamsadatta, I've dedicated some time to delve into this issue (see frankaemika/franka_ros#172 (comment)). It appears that Franka has made specific enhancements to the simulated gripper actions. While the /franka_gripper/grasp/goal can now effectively grasp objects, it falls short when setting a specific gripper width. Conversely, the /franka_gripper/gripper_action/goal can manipulate the gripper's position but cannot grasp objects. I'll explore potential workarounds briefly, but a resolution from @frankaemika upstream must address this issue comprehensively.

@rickstaa rickstaa changed the title The franka_gazebo gripper action currently doesn't work The franka_gazebo gripperAction Action Service implementation should be improved Nov 22, 2023
@rickstaa rickstaa changed the title The franka_gazebo gripperAction Action Service implementation should be improved The franka_gazebo gripperAction action Service implementation should be improved Nov 22, 2023
@rickstaa rickstaa self-assigned this Dec 13, 2023
@rickstaa rickstaa mentioned this issue Dec 13, 2023
rickstaa added a commit that referenced this issue Dec 13, 2023
This commit ensures that the gripper always ignores the gripper_width
when grasping. This was done since we currently don't use the
`frank_gripper/grasp` action service to grasp objects based on their
width.

BREAKING CHANGE: brute_force_grasping is depricated

\#33
@rickstaa
Copy link
Owner Author

@hamsadatta I just merged #199, which makes brute_force_grasping the default and depricates the launchfile argument. Grasping should now work in the simulation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Problems caused by upstream issues.
Projects
None yet
Development

No branches or pull requests

2 participants