Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sstc extension #395

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Sstc extension #395

wants to merge 1 commit into from

Conversation

ved-rivos
Copy link
Contributor

No description provided.

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, will aim to do a full review of the logic soon

model/riscv_platform.sail Outdated Show resolved Hide resolved
model/riscv_csr_map.sail Show resolved Hide resolved
model/riscv_csr_map.sail Show resolved Hide resolved
model/riscv_sys_regs.sail Outdated Show resolved Hide resolved
model/riscv_sys_regs.sail Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 26, 2024

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e7a5236. ± Comparison against base commit 40ed0c5.

♻️ This comment has been updated with latest results.

@Timmmm
Copy link
Collaborator

Timmmm commented Aug 6, 2024

LGTM, needs rebasing & there are some old style bit accesses (menvcfg.STCE()).

Also do you need to handle the fact that mip[STI] is writable or not depending on whether this extension is implemented:

If the stimecmp register is not implemented, STIP is writable in mip, and may be written by M-mode software to deliver timer interrupts to S-mode. If the stimecmp (supervisor-mode timer compare) register is implemented, STIP is read-only in mip and reflects the supervisor-level timer interrupt signal resulting from stimecmp.

@Timmmm Timmmm self-requested a review October 2, 2024 08:26
@Timmmm Timmmm mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants