Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sstc extension #570

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Sstc extension #570

wants to merge 1 commit into from

Conversation

Timmmm
Copy link
Collaborator

@Timmmm Timmmm commented Oct 2, 2024

This adds the stimecmp[h] CSRs. It is enabled by default.

The code is slightly unfortunately structured to handle CSRs that don't fit the standard permission checks. I added a TODO to improve it.

@Timmmm
Copy link
Collaborator Author

Timmmm commented Oct 2, 2024

This is a rebase of #395 by @ved-rivos. The model structure has changed a bit so it required fairly extensive changes. I also added a command line flag.

model/riscv_sys_regs.sail Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 2, 2024

Test Results

396 tests  ±0   396 ✅ ±0   0s ⏱️ ±0s
  4 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit ef365f8. ± Comparison against base commit 87f8bb3.

♻️ This comment has been updated with latest results.

@Alasdair
Copy link
Collaborator

Alasdair commented Oct 2, 2024

Yes, I think having a is_csr_accessible function might be a good idea

This adds the stimecmp[h] CSRs. It is enabled by default.

The code is slightly unfortunately structured to handle CSRs that don't fit the standard permission checks. I added a TODO to improve it.

Co-authored-by: Tim Hutt <[email protected]>
@Timmmm
Copy link
Collaborator Author

Timmmm commented Oct 10, 2024

☝️ rebased and fixed a missing & xlen == 32 on the stimecmph CSR that was found in testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants