Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor arrow conversion #18608

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 19, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Make it easier to maintain and understand.
And prepare for bump arrow-udf version.

(One specific reason is that arrow-udf and arrow-iceberg will both use arrow-52, and the old impl is not compatible)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan marked this pull request as ready for review September 19, 2024 12:45
@xxchan xxchan requested a review from a team as a code owner September 19, 2024 12:45
@xxchan xxchan requested a review from hzxa21 September 19, 2024 12:45
@graphite-app graphite-app bot requested a review from a team September 19, 2024 12:45
Copy link
Member Author

xxchan commented Sep 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan force-pushed the 09-19-refactor_refactor_arrow_conversion branch from 748835c to 898d0be Compare September 19, 2024 12:47
@graphite-app graphite-app bot requested a review from a team September 19, 2024 13:22
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really COOL

@xxchan xxchan added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit c6db801 Sep 20, 2024
30 of 31 checks passed
@xxchan xxchan deleted the 09-19-refactor_refactor_arrow_conversion branch September 20, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants