build(deps): bump arrow-udf to use arrow 52 #18609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
xxchan
force-pushed
the
09-19-build_deps_bump_arrow-udf_to_use_arrow_52
branch
from
325bceb
to
2818887
Compare
xxchan
commented
Sep 19, 2024
Comment on lines
+139
to
141
| # branch rw_patch | ||
| icelake = { git = "https://github.com/risingwavelabs/icelake.git", rev = "db4868f9a5de8ff8f6c04ec4c203bcbe59564cbe", features = [ | ||
| "prometheus", |
There was a problem hiding this comment.
Pushed a new commit in icelake to pin arrow & opendal major version
xxchan
force-pushed
the
09-19-build_deps_bump_arrow-udf_to_use_arrow_52
branch
3 times, most recently
from
9268e4f
to
99f942a
Compare
|
Is this going to supersede #17544 ? |
BugenZhao
approved these changes
Sep 20, 2024
src/expr/impl/Cargo.toml
Outdated
Comment on lines
71
to
73
| # For arrow-udf-flight | ||
| tonic = { version = "0.11", optional = true } |
There was a problem hiding this comment.
Can you keep TODO(http-bump) so that we can easily find it?
Base automatically changed from
09-19-refactor_refactor_arrow_conversion
to
main
September 20, 2024 06:52
This might solve a large pain point: Whenever we modify any entry in Cargo.toml, arrow will be affected. rust-lang/cargo#14115
xxchan
force-pushed
the
09-19-build_deps_bump_arrow-udf_to_use_arrow_52
branch
from
99f942a
to
f2b1812
Compare
Signed-off-by: xxchan <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This might solve a large pain point: Whenever we modify any entry in Cargo.toml, arrow will be affected (rust-lang/cargo#14115). Because arrow-udf doesn't use
>=version any moreChecklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.