Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-emphasise dividing lines when rendering German Lute Tablature #3589

Closed
musicog opened this issue Feb 5, 2024 · 0 comments
Closed

De-emphasise dividing lines when rendering German Lute Tablature #3589

musicog opened this issue Feb 5, 2024 · 0 comments

Comments

@musicog
Copy link
Contributor

musicog commented Feb 5, 2024

This issue concerns the rendering of German Lute Tablature (GLT) as implemented by @paul-bayleaf and currently available in branch develop-tab.

image

The image above displays the current rendering produced for an example GLT encoding as of PR #3581. It's wonderful to see this rendering in Verovio! However, having run the output by @Kateryna333 (Kateryna Schöning, P.I., E-LAUTE), I would like to forward her suggestion to de-emphasise the dividing lines between systems, by:

  1. slightly lowering the lines to ensure no contact between the note glyphs and the dividers, and
  2. making the dividing lines lighter in colour so as not to dominate the image

This would allow the lines to better serve in their intended role as reading aids, without becoming distracting.

It's possible that 1. is font-dependent -- the glyphs are sufficiently separated from the lines when the Bravura font is specified:

image

paul-bayleaf added a commit to paul-bayleaf/verovio that referenced this issue Feb 6, 2024
lpugin added a commit that referenced this issue Feb 7, 2024
…-dividing-lines

Fix issue #3589 GLT de-emphasise dividing lines
@lpugin lpugin closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants