Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3589 GLT de-emphasise dividing lines #3590

Conversation

paul-bayleaf
Copy link
Contributor

Fix issue #3589 Slightly move dividing lines down and reduce line thickness. (Also added a trivial but unconnected fix for when @lines.visible="true" for GLT).

Leipzig font before this pull request
before-Leipzig

Leipzig font after this pull request, slight lower and thinner dividing lines
after-Leipzig

Bravura font before this pull request
before-Bravura

Bravura font after this pull request, slight lower and thinner dividing lines
after-Bravura

@lpugin lpugin requested a review from musicog February 6, 2024 14:10
Copy link
Contributor

@musicog musicog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting around to this so quickly! Looks good to me.

@lpugin lpugin merged commit a76ebf2 into rism-digital:develop-tab Feb 7, 2024
4 checks passed
@paul-bayleaf paul-bayleaf deleted the develop-tab-issue-3589-GLT-dividing-lines branch February 7, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants