Skip to content

Commit

Permalink
Minor grammar corrections on benchmark comments (#260)
Browse files Browse the repository at this point in the history
Follows up #259 that added some client configuration tweaks for
benchmarks along with comments describing their selection. This is my
fault for merging without waiting for review, but there was a minor
grammatical mistake and omitted word, which we fix up here.
  • Loading branch information
brandur authored Mar 11, 2024
1 parent 9f992c4 commit 7d4f3cc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cmd/river/riverbench/river_bench.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func (b *Benchmarker[TTx]) Run(ctx context.Context) error {

client, err := river.NewClient(b.driver, &river.Config{
// When benchmarking to maximize job throughput these numbers have an
// outside effect on results. The ones chosen here could possibly be
// outsized effect on results. The ones chosen here could possibly be
// optimized further, but based on my tests of throwing a lot of random
// values against the wall, they perform quite well. Much better than
// the client's default values at any rate.
Expand All @@ -101,7 +101,7 @@ func (b *Benchmarker[TTx]) Run(ctx context.Context) error {
// This could probably use more refinement, but in my quick and
// dirty tests I found that roughly 1k workers was most optimal. 500
// and 2,000 performed a little more poorly, and jumping up to the
// 10k performed considerably less well (scheduler contention?).
// maximum of 10k performed quite badly (scheduler contention?).
// There may be a more optimal number than 1,000, but it seems close
// enough to target for now.
river.QueueDefault: {MaxWorkers: 1_000},
Expand Down

0 comments on commit 7d4f3cc

Please sign in to comment.