Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for NumericQuadraticFunction with dynamic allocation checking #91

Merged
merged 1 commit into from
Apr 13, 2015
Merged

Fix for NumericQuadraticFunction with dynamic allocation checking #91

merged 1 commit into from
Apr 13, 2015

Conversation

fdarricau
Copy link
Contributor

Proposing a solution for the issue #90.

Basically using the Sparse way again. It works for both RowMajor and ColMajor modes.

@bchretien
Copy link
Member

AFAIK, coeffRef should not be used in the dense case, we use it for the sparse specialization because gradient (gradient_t) is sparse while buffer (vector_t) is dense. I guess we could even use gradient = buffer_.sparseView(); there.

@fdarricau
Copy link
Contributor Author

I see.

I will update the PR.

@bchretien
Copy link
Member

Ok, LGTM, you can rebase the 2 commits.

@bchretien bchretien changed the title fix for the rowVector related issue Fix for NumericQuadraticFunction with dynamic allocation checking Apr 13, 2015
bchretien added a commit that referenced this pull request Apr 13, 2015
@bchretien
Merge pull request #91 from fdarricau/master
793e71c 
Fix for NumericQuadraticFunction with dynamic allocation checking
@bchretien bchretien merged commit 793e71c into roboptim:master Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdarricau @bchretien