-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address sdformat11 deprecations #321
Conversation
8a57fef
to
22eb2cf
Compare
22eb2cf
to
2f15bde
Compare
9215127
to
38c513f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, this changes the public ABI and API of the C++ Scenario package. If the project follows semantic versioning (see #81 (comment)) this would mean that the major version needs to bump? If instead the compatibility policy is not semantic versioning (even for a subset of the project) it would be convenient to document it in the README, for downstream packages.
Uhm, the // OLD
std::string getModelNameFromSdf(const std::string& fileName,
const size_t modelIndex = 0);
// NEW
std::string getModelNameFromSdf(const std::string& fileName); I'm debating about how to handle the process. The PR targets I think it's safe saying that we follow semantic versioning only for the ScenarIO interface. This is not part of it and I agree that we should document it somewhere. |
For convenient of downstream packages, it would be convenient to specify a API/ABI policy also for the part of ScenarIO that are not part of the interface, even just something as limited as API/ABI is not broken as part of the same patch release |
Yep, while you were commenting I opened #337 as reminder. |
Updates the code to sdformat11, and particularly complies with gazebosim/sdformat#444.
This PR depends on #307 for Edifice support, and #318 for disabling Dome in CI.