Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align empty world with upstream #336

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Align empty world with upstream #336

merged 2 commits into from
Apr 28, 2021

Conversation

diegoferigo
Copy link
Member

This PR aligns with upstream's default.sdf the empty world that is used when no sdf if passed to the GazeboSimulator. In our case there is no ground.

const std::string world = R""""(<?xml version="1.0" ?>
<sdf version="1.6">
<world name="default">
<physics default="true" type="dart">
<physics default="true" type="ignored">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a spec compliant SDF, but this is definitely not related to this PR, I opened gazebosim/sdformat#550 for track the actual problem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think that currently Ignition supports selecting physics engine through the PhysicsEnginePlugin introduced in gazebosim/gz-sim#136 (couldn't find the actual PR). I already have a local branch that I'm about to push that introduces that component in our logic. I'm not really sure whether the /world/physics@type attribute is even read nor supported in Ignition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I'll proceed merging as it is. We can update it as soon as we figure this out, both current and new attributes are not breaking any existing logic.

@diegoferigo diegoferigo merged commit 9394833 into devel Apr 28, 2021
@diegoferigo diegoferigo deleted the update_default_world branch April 28, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants