New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A potential bug in Flame.cc #10

Open

xing-mei opened this issue Jan 24, 2020 · 2 comments

xing-mei commented Jan 24, 2020

Hi @wngreene
https://github.com/robustrobotics/flame/blob/master/src/flame/flame.cc#L174 indicates this block only runs when feats_ is empty, but inside this block https://github.com/robustrobotics/flame/blob/master/src/flame/flame.cc#L220 only executes when feats_ is not empty. So this part never runs?

The text was updated successfully, but these errors were encountered:

Member

wngreene commented Jan 24, 2020

Ah. Yeah you could be right. Looks like the block at L220 shouldn't run.

Author

xing-mei commented Jan 31, 2020

thanks for confirmation @wngreene , another question about https://github.com/robustrobotics/flame/blob/master/src/flame/flame.cc#L1228
thought it should be cv::Point2f(jj, ii)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment