-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log RecordNotFound as 404 #112
Conversation
👍 |
e66d854
to
682e873
Compare
@pxlpnk - Any plans to release a new version of the gem with this fix? |
@jturkel I'll cut a release. Watch this space. |
Is there a way to do the same for |
Yes. Eg:
Any ideas why it could happen? |
This happens in the rack stack. lograge currently can not handle those errors. |
Ah, gotcha. Thanks for the explanation @pxlpnk!! |
This is an attempt/proposal to fix #110 and parts of #27.
It will correctly log an
ActiveRecord::RecordNotFound
as a 404 and other things coming back from AR and others.It will however not log a
ActionController::RoutingError
as this is out of reach with the current implementation. See the referenced issues for this.