Don't attempt to create exception classes #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #126 by not attempting to create exception classes. A
couple of points no less:
ActiveRecord
specific exceptions are loaded and merged whenits railtie is loaded. Our tests do not load
ActiveRecord
so whilethey don't exist in our context, they will be around in your garden
variety rails application.
ExceptionWrapper
was doing forus, but by leveraging
Rack::Utils.status_code
we avoid the need tocreate an instance of the actual exception class. Thus avoiding the
problems experienced creating exceptions that expect initializer
arguments.