more examples of accepted expressions

rome · Nov 9, 2022 · f98920e · f98920e
1 parent eced59e
commit f98920e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/crates/rome_js_analyze/src/analyzers/a11y/use_valid_anchor.rs b/crates/rome_js_analyze/src/analyzers/a11y/use_valid_anchor.rs
@@ -313,15 +313,11 @@ fn is_invalid_anchor(anchor_attribute: &JsxAttribute) -> Option<UseValidAnchorSt
                 JsAnyExpression::ImportMeta(_)
                 | JsAnyExpression::JsClassExpression(_)
                 | JsAnyExpression::JsImportCallExpression(_)
-                | JsAnyExpression::JsLogicalExpression(_)
                 | JsAnyExpression::JsObjectExpression(_)
                 | JsAnyExpression::JsSuperExpression(_)
                 | JsAnyExpression::JsUnaryExpression(_)
-                | JsAnyExpression::JsUnknownExpression(_)
-                | JsAnyExpression::JsYieldExpression(_)
                 | JsAnyExpression::JsxTagExpression(_)
-                | JsAnyExpression::NewTarget(_)
-                | JsAnyExpression::TsNonNullAssertionExpression(_) => {
+                | JsAnyExpression::NewTarget(_) => {
                     return Some(UseValidAnchorState::IncorrectHref(
                         expression.syntax().text_trimmed_range(),
                     ));

diff --git a/crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx b/crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx
@@ -22,4 +22,5 @@
     <a href={1 + 2}>Download</a>
     <a href={await getLink()}>Download</a>
     <a href={a["a"]}>Download</a>
+    <a href={true ?? "url"}>Download</a>
 </>
diff --git a/crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx.snap b/crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx.snap
@@ -28,6 +28,7 @@ expression: useValidAnchor.jsx
     <a href={1 + 2}>Download</a>
     <a href={await getLink()}>Download</a>
     <a href={a["a"]}>Download</a>
+    <a href={true ?? "url"}>Download</a>
 </>
 ```