Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_lsp): lsp friendly catch unwind #3740

Merged
merged 4 commits into from
Nov 23, 2022
Merged

fix(rome_lsp): lsp friendly catch unwind #3740

merged 4 commits into from
Nov 23, 2022

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Nov 15, 2022

Summary

Partial fix for #3697.
This do not solve the problem. But will allow us to diagnostic similar problem in the future.

Test Plan

Type the "romeKiller" example of #3697 and vscode will print the message below. Important part is that the server do not dies now.

[Error - 10:04:16] Request textDocument/codeAction failed.
  Message: panicked at 'cannot replace element in slot 0 with 1 removed slots', C:\github\tools\crates\rome_rowan\src\ast\batch.rs:360:85
Backtrace:    0: std::backtrace_rs::backtrace::dbghelp::trace
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\std\src\..\..\backtrace\src\backtrace\dbghelp.rs:98
   1: std::backtrace_rs::backtrace::trace_unsynchronized
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66
   2: std::backtrace::Backtrace::create
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\std\src\backtrace.rs:333
   3: std::backtrace::Backtrace::capture
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\std\src\backtrace.rs:298
   4: rome_diagnostics::v2::catch_unwind::closure$0<rome_lsp::server::impl$5::code_action::async_block$0::closure_env$0,enum2$<core::result::Result<enum2$<core::option::Option<alloc::vec::Vec<enum2$<lsp_types::code_action::CodeActionOrCommand>,alloc::alloc::Glo
             at C:\github\tools\crates\rome_diagnostics\src\v2\mod.rs:63
   5: std::panicking::rust_panic_with_hook
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\std\src\panicking.rs:702
   6: std::panicking::begin_panic_handler::closure$0
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\std\src\panicking.rs:588
   7: std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure_env$0,never$>
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\std\src\sys_common\backtrace.rs:138
   8: std::panicking::begin_panic_handler
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\std\src\panicking.rs:584
   9: core::panicking::panic_fmt
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\core\src\panicking.rs:142
  10: rome_rowan::ast::batch::impl$6::commit::closure$2<rome_js_syntax::syntax_node::JsLanguage>
             at C:\github\tools\crates\rome_rowan\src\ast\batch.rs:360
  11: enum2$<core::option::Option<usize> >::unwrap_or_else<usize,rome_rowan::ast::batch::impl$6::commit::closure_env$2<rome_js_syntax::syntax_node::JsLanguage> >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\option.rs:825
  12: rome_rowan::ast::batch::BatchMutation<rome_js_syntax::syntax_node::JsLanguage>::commit<rome_js_syntax::syntax_node::JsLanguage>
             at C:\github\tools\crates\rome_rowan\src\ast\batch.rs:360
  13: rome_rowan::ast::batch::BatchMutation<rome_js_syntax::syntax_node::JsLanguage>::as_text_edits<rome_js_syntax::syntax_node::JsLanguage>
             at C:\github\tools\crates\rome_rowan\src\ast\batch.rs:296
  14: rome_analyze::signals::impl$3::from<rome_js_syntax::syntax_node::JsLanguage>
             at C:\github\tools\crates\rome_analyze\src\signals.rs:85
  15: rome_service::file_handlers::javascript::code_actions::closure$0
             at C:\github\tools\crates\rome_service\src\file_handlers\javascript.rs:332
  16: core::ops::function::impls::impl$3::call_mut<tuple$<ref$<dyn$<rome_analyze::signals::AnalyzerSignal<rome_js_syntax::syntax_node::JsLanguage> > > >,dyn$<core::ops::function::FnMut<tuple$<ref$<dyn$<rome_analyze::signals::AnalyzerSignal<rome_js_syntax::synta
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\ops\function.rs:294
  17: rome_analyze::PhaseRunner<rome_js_syntax::syntax_node::JsLanguage,rome_analyze::matcher::InspectMatcher<rome_js_analyze::analyze::closure_env$0<rome_service::file_handlers::javascript::code_actions::closure_env$0,enum2$<rome_analyze::Never> >,rome_analyze
             at C:\github\tools\crates\rome_analyze\src\lib.rs:380
  18: rome_analyze::PhaseRunner<rome_js_syntax::syntax_node::JsLanguage,rome_analyze::matcher::InspectMatcher<rome_js_analyze::analyze::closure_env$0<rome_service::file_handlers::javascript::code_actions::closure_env$0,enum2$<rome_analyze::Never> >,rome_analyze
             at C:\github\tools\crates\rome_analyze\src\lib.rs:283
  19: rome_analyze::Analyzer<rome_js_syntax::syntax_node::JsLanguage,rome_analyze::matcher::InspectMatcher<rome_js_analyze::analyze::closure_env$0<rome_service::file_handlers::javascript::code_actions::closure_env$0,enum2$<rome_analyze::Never> >,rome_analyze::r
             at C:\github\tools\crates\rome_analyze\src\lib.rs:147
  20: rome_js_analyze::analyze_with_inspect_matcher<rome_js_analyze::analyze::closure_env$0<rome_service::file_handlers::javascript::code_actions::closure_env$0,enum2$<rome_analyze::Never> >,rome_service::file_handlers::javascript::code_actions::closure_env$0,e
             at C:\github\tools\crates\rome_js_analyze\src\lib.rs:92
  21: rome_js_analyze::analyze<rome_service::file_handlers::javascript::code_actions::closure_env$0,enum2$<rome_analyze::Never> >
             at C:\github\tools\crates\rome_js_analyze\src\lib.rs:115
  22: rome_service::file_handlers::javascript::code_actions
             at C:\github\tools\crates\rome_service\src\file_handlers\javascript.rs:327
  23: rome_service::workspace::server::impl$3::pull_actions
             at C:\github\tools\crates\rome_service\src\workspace\server.rs:417
  24: rome_lsp::handlers::analysis::code_actions::closure$0
             at C:\github\tools\crates\rome_lsp\src\handlers\analysis.rs:68
  25: rome_lsp::handlers::analysis::code_actions
             at C:\github\tools\crates\rome_lsp\src\handlers\analysis.rs:27
  26: rome_lsp::server::impl$5::code_action::async_block$0::closure$0
             at C:\github\tools\crates\rome_lsp\src\server.rs:291
  27: std::panicking::try::do_call<rome_lsp::server::impl$5::code_action::async_block$0::closure_env$0,enum2$<core::result::Result<enum2$<core::option::Option<alloc::vec::Vec<enum2$<lsp_types::code_action::CodeActionOrCommand>,alloc::alloc::Global> > >,tower_ls
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panicking.rs:492
  28: std::panicking::try::do_catch<rome_lsp::server::impl$5::rename::async_block$0::closure_env$0,enum2$<core::result::Result<enum2$<core::option::Option<lsp_types::WorkspaceEdit> >,tower_lsp::jsonrpc::error::Error> > >
  29: std::panicking::try<enum2$<core::result::Result<enum2$<core::option::Option<alloc::vec::Vec<enum2$<lsp_types::code_action::CodeActionOrCommand>,alloc::alloc::Global> > >,tower_lsp::jsonrpc::error::Error> >,rome_lsp::server::impl$5::code_action::async_bloc
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panicking.rs:456
  30: std::panic::catch_unwind<rome_lsp::server::impl$5::code_action::async_block$0::closure_env$0,enum2$<core::result::Result<enum2$<core::option::Option<alloc::vec::Vec<enum2$<lsp_types::code_action::CodeActionOrCommand>,alloc::alloc::Global> > >,tower_lsp::j
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panic.rs:137
  31: rome_diagnostics::v2::catch_unwind<rome_lsp::server::impl$5::code_action::async_block$0::closure_env$0,enum2$<core::result::Result<enum2$<core::option::Option<alloc::vec::Vec<enum2$<lsp_types::code_action::CodeActionOrCommand>,alloc::alloc::Global> > >,to
             at C:\github\tools\crates\rome_diagnostics\src\v2\mod.rs:72
  32: rome_lsp::server::impl$5::code_action::async_block$0
             at C:\github\tools\crates\rome_lsp\src\server.rs:290
  33: core::future::from_generator::impl$1::poll<enum2$<rome_lsp::server::impl$5::code_action::async_block_env$0> >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\mod.rs:91
  34: core::future::future::impl$1::poll<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<alloc::vec::Vec<enum2$<lsp_types::code_action::CodeActionOrCommand>,alloc::alloc::Global> > >,towe
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\future.rs:124
  35: tower_lsp::generated::register_lsp_methods::code_action::async_fn$0<rome_lsp::server::LSPServer>
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tower-lsp-0.17.0\src\lib.rs:110
  36: core::future::from_generator::impl$1::poll<enum2$<tower_lsp::generated::register_lsp_methods::code_action::async_fn_env$0<rome_lsp::server::LSPServer> > >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\mod.rs:91
  37: tower_lsp::jsonrpc::router::impl$0::method::closure$0::closure$0::async_block$0<rome_lsp::server::LSPServer,tower_lsp::service::ExitedError,tuple$<lsp_types::code_action::CodeActionParams>,enum2$<core::result::Result<enum2$<core::option::Option<alloc::vec
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tower-lsp-0.17.0\src\jsonrpc\router.rs:53
  38: core::future::from_generator::impl$1::poll<enum2$<tower_lsp::jsonrpc::router::impl$0::method::closure$0::closure$0::async_block_env$0<rome_lsp::server::LSPServer,tower_lsp::service::ExitedError,tuple$<lsp_types::code_action::CodeActionParams>,enum2$<core:
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\mod.rs:91
  39: core::future::future::impl$1::poll<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<alloc::vec::Vec<enum2$<lsp_types::code_action::CodeActionOrCommand>,alloc::alloc::Global> > >,towe
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\future.rs:124
  40: futures_util::future::future::map::impl$2::poll<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<alloc::vec::Vec<enum2$<lsp_types::code_action::CodeActionOrCommand>,al
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\future\future\map.rs:55
  41: futures_util::future::future::impl$15::poll<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<alloc::vec::Vec<enum2$<lsp_types::code_action::CodeActionOrCommand>,alloc:
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\lib.rs:91
  42: core::future::future::impl$1::poll<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::ExitedError> > > >,core::marker::Send>,alloc::
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\future.rs:124
  43: futures_util::abortable::impl$5::poll::closure$0<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::ExitedError> > > 
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\abortable.rs:159
  44: futures_util::abortable::Abortable<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::ExitedError> > > >,core::marker
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\abortable.rs:133
  45: futures_util::abortable::impl$5::poll<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::ExitedError> > > >,core::mar
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\abortable.rs:159
  46: tower_lsp::service::pending::impl$0::execute::async_block$0<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::Exited
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tower-lsp-0.17.0\src\service\pending.rs:42
  47: core::future::from_generator::impl$1::poll<enum2$<tower_lsp::service::pending::impl$0::execute::async_block_env$0<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<towe
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\mod.rs:91
  48: futures_util::future::either::impl$4::poll<core::future::from_generator::GenFuture<enum2$<tower_lsp::service::pending::impl$0::execute::async_block_env$0<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result:
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\future\either.rs:89
  49: core::future::future::impl$1::poll<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::ExitedError> > > >,core::marker::Send>,alloc::
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\future.rs:124
  50: core::future::future::impl$1::poll<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::ExitedError> > > >,core::marker::Send>,alloc::
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\future.rs:124
  51: tower_lsp::service::impl$3::call::async_block$0<rome_lsp::server::LSPServer>
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tower-lsp-0.17.0\src\service.rs:119
  52: core::future::from_generator::impl$1::poll<enum2$<tower_lsp::service::impl$3::call::async_block_env$0<rome_lsp::server::LSPServer> > >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\mod.rs:91
  53: core::future::future::impl$1::poll<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::ExitedError> > > >,core::marker::Send>,alloc::
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\future.rs:124
  54: futures_core::future::impl$2::try_poll<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::ExitedError> > > >,core::ma
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-core-0.3.23\src\future.rs:82
  55: futures_util::future::try_future::into_future::impl$2::poll<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::Exited
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\future\try_future\into_future.rs:34
  56: futures_util::future::future::map::impl$2::poll<futures_util::future::try_future::into_future::IntoFuture<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::j
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\future\future\map.rs:55
  57: futures_util::future::future::impl$15::poll<futures_util::future::try_future::into_future::IntoFuture<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonr
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\lib.rs:91
  58: futures_util::future::try_future::impl$71::poll<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::jsonrpc::Response> >,tower_lsp::service::ExitedError> > > >
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\lib.rs:91
  59: futures_util::stream::futures_unordered::impl$7::poll_next<futures_util::future::try_future::UnwrapOrElse<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<enum2$<core::option::Option<tower_lsp::j
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\stream\futures_unordered\mod.rs:514
  60: futures_util::stream::stream::StreamExt::poll_next_unpin<futures_util::stream::futures_unordered::FuturesUnordered<futures_util::future::try_future::UnwrapOrElse<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core:
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\stream\stream\mod.rs:1626
  61: futures_util::stream::stream::buffer_unordered::impl$2::poll_next<futures_channel::mpsc::Receiver<futures_util::future::try_future::UnwrapOrElse<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::future::Future<assoc$<Output,enum2$<core::result::Result<e
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\stream\stream\buffer_unordered.rs:79
  62: futures_util::stream::stream::filter_map::impl$3::poll_next<futures_util::stream::stream::buffer_unordered::BufferUnordered<futures_channel::mpsc::Receiver<futures_util::future::try_future::UnwrapOrElse<core::pin::Pin<alloc::boxed::Box<dyn$<core::future::
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\stream\stream\filter_map.rs:79
  63: futures_util::stream::stream::map::impl$3::poll_next<futures_util::stream::stream::filter_map::FilterMap<futures_util::stream::stream::buffer_unordered::BufferUnordered<futures_channel::mpsc::Receiver<futures_util::future::try_future::UnwrapOrElse<core::p
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\stream\stream\map.rs:58
  64: futures_util::stream::stream::fuse::impl$2::poll_next<futures_util::stream::stream::map::Map<futures_util::stream::stream::filter_map::FilterMap<futures_util::stream::stream::buffer_unordered::BufferUnordered<futures_channel::mpsc::Receiver<futures_util::
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\stream\stream\fuse.rs:53
  65: futures_util::stream::stream::forward::impl$2::poll<futures_util::stream::stream::map::Map<futures_util::stream::stream::filter_map::FilterMap<futures_util::stream::stream::buffer_unordered::BufferUnordered<futures_channel::mpsc::Receiver<futures_util::fu
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\stream\stream\forward.rs:59
  66: futures_util::stream::stream::impl$11::poll<futures_util::stream::stream::map::Map<futures_util::stream::stream::filter_map::FilterMap<futures_util::stream::stream::buffer_unordered::BufferUnordered<futures_channel::mpsc::Receiver<futures_util::future::tr
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\lib.rs:91
  67: futures_util::future::future::map::impl$2::poll<futures_util::stream::stream::Forward<futures_util::stream::stream::map::Map<futures_util::stream::stream::filter_map::FilterMap<futures_util::stream::stream::buffer_unordered::BufferUnordered<futures_channe
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\future\future\map.rs:55
  68: futures_util::future::future::impl$15::poll<futures_util::stream::stream::Forward<futures_util::stream::stream::map::Map<futures_util::stream::stream::filter_map::FilterMap<futures_util::stream::stream::buffer_unordered::BufferUnordered<futures_channel::m
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\lib.rs:91
  69: futures_util::future::maybe_done::impl$3::poll<futures_util::future::future::Map<futures_util::stream::stream::Forward<futures_util::stream::stream::map::Map<futures_util::stream::stream::filter_map::FilterMap<futures_util::stream::stream::buffer_unordere
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\future\maybe_done.rs:95
  70: tower_lsp::transport::impl$1::serve::async_fn$0::closure$6<rome_cli::service::windows::ServerReadHalf,rome_cli::service::windows::ServerWriteHalf,tower_lsp::service::client::socket::ClientSocket,tower_lsp::service::LspService<rome_lsp::server::LSPServer> 
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\async_await\join_mod.rs:95
  71: futures_util::future::poll_fn::impl$2::poll<tuple$<tuple$<>,tuple$<>,tuple$<> >,tower_lsp::transport::impl$1::serve::async_fn$0::closure_env$6<rome_cli::service::windows::ServerReadHalf,rome_cli::service::windows::ServerWriteHalf,tower_lsp::service::clien
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-util-0.3.23\src\future\poll_fn.rs:56
  72: tower_lsp::transport::impl$1::serve::async_fn$0<rome_cli::service::windows::ServerReadHalf,rome_cli::service::windows::ServerWriteHalf,tower_lsp::service::client::socket::ClientSocket,tower_lsp::service::LspService<rome_lsp::server::LSPServer> >
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tower-lsp-0.17.0\src\transport.rs:163
  73: core::future::from_generator::impl$1::poll<enum2$<tower_lsp::transport::impl$1::serve::async_fn_env$0<rome_cli::service::windows::ServerReadHalf,rome_cli::service::windows::ServerWriteHalf,tower_lsp::service::client::socket::ClientSocket,tower_lsp::servic
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\mod.rs:91
  74: rome_lsp::server::impl$4::accept::async_fn$0<rome_cli::service::windows::ServerReadHalf,rome_cli::service::windows::ServerWriteHalf>
             at C:\github\tools\crates\rome_lsp\src\server.rs:485
  75: core::future::from_generator::impl$1::poll<enum2$<rome_lsp::server::impl$4::accept::async_fn_env$0<rome_cli::service::windows::ServerReadHalf,rome_cli::service::windows::ServerWriteHalf> > >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\mod.rs:91
  76: rome_cli::service::windows::run_server::async_fn$0
             at C:\github\tools\crates\rome_cli\src\service\windows.rs:197
  77: core::future::from_generator::impl$1::poll<enum2$<rome_cli::service::windows::run_server::async_fn_env$0> >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\future\mod.rs:91
  78: tracing::instrument::impl$0::poll<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::async_fn_env$0> > >
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tracing-0.1.36\src\instrument.rs:272
  79: tokio::runtime::task::core::impl$3::poll::closure$0<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::async_fn_env$0> > > >
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\core.rs:165
  80: tokio::loom::std::unsafe_cell::UnsafeCell<enum2$<tokio::runtime::task::core::Stage<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::async_fn_env$0> > > > > >::with_mut<enum2$<tokio::r
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\loom\std\unsafe_cell.rs:14
  81: tokio::runtime::task::core::CoreStage<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::async_fn_env$0> > > >::poll<tracing::instrument::Instrumented<core::future::from_generator::GenF
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\core.rs:155
  82: tokio::runtime::task::harness::poll_future::closure$0<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::async_fn_env$0> > >,alloc::sync::Arc<tokio::runtime::thread_pool::worker::Shared
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\harness.rs:480
  83: core::panic::unwind_safe::impl$23::call_once<enum2$<core::task::poll::Poll<tuple$<> > >,tokio::runtime::task::harness::poll_future::closure_env$0<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\panic\unwind_safe.rs:271
  84: std::panicking::try::do_call<core::panic::unwind_safe::AssertUnwindSafe<tokio::runtime::task::harness::poll_future::closure_env$0<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::asyn
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panicking.rs:492
  85: std::panicking::try::do_catch<core::panic::unwind_safe::AssertUnwindSafe<tokio::runtime::task::harness::impl$1::drop_join_handle_slow::closure_env$0<core::future::from_generator::GenFuture<enum2$<rome_cli::service::write_task::async_fn_env$0<rome_cli::ser
  86: std::panicking::try<enum2$<core::task::poll::Poll<tuple$<> > >,core::panic::unwind_safe::AssertUnwindSafe<tokio::runtime::task::harness::poll_future::closure_env$0<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panicking.rs:456
  87: std::panic::catch_unwind<core::panic::unwind_safe::AssertUnwindSafe<tokio::runtime::task::harness::poll_future::closure_env$0<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::async_fn
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panic.rs:137
  88: tokio::runtime::task::harness::poll_future<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::async_fn_env$0> > >,alloc::sync::Arc<tokio::runtime::thread_pool::worker::Shared> >
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\harness.rs:468
  89: tokio::runtime::task::harness::Harness<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::async_fn_env$0> > >,alloc::sync::Arc<tokio::runtime::thread_pool::worker::Shared> >::poll_inner
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\harness.rs:104
  90: tokio::runtime::task::harness::Harness<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::async_fn_env$0> > >,alloc::sync::Arc<tokio::runtime::thread_pool::worker::Shared> >::poll<traci
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\harness.rs:57
  91: tokio::runtime::task::raw::poll<tracing::instrument::Instrumented<core::future::from_generator::GenFuture<enum2$<rome_cli::service::windows::run_server::async_fn_env$0> > >,alloc::sync::Arc<tokio::runtime::thread_pool::worker::Shared> >
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\raw.rs:144
  92: tokio::runtime::task::raw::RawTask::poll
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\raw.rs:84
  93: tokio::runtime::task::LocalNotified<alloc::sync::Arc<tokio::runtime::thread_pool::worker::Shared> >::run<alloc::sync::Arc<tokio::runtime::thread_pool::worker::Shared> >
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\mod.rs:381
  94: tokio::runtime::thread_pool::worker::impl$1::run_task::closure$0
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\thread_pool\worker.rs:435
  95: tokio::coop::with_budget::closure$0<enum2$<core::result::Result<alloc::boxed::Box<tokio::runtime::thread_pool::worker::Core,alloc::alloc::Global>,tuple$<> > >,tokio::runtime::thread_pool::worker::impl$1::run_task::closure_env$0>
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\coop.rs:102
  96: std::thread::local::LocalKey<core::cell::Cell<tokio::coop::Budget> >::try_with<core::cell::Cell<tokio::coop::Budget>,tokio::coop::with_budget::closure_env$0<enum2$<core::result::Result<alloc::boxed::Box<tokio::runtime::thread_pool::worker::Core,alloc::all
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\thread\local.rs:445
  97: std::thread::local::LocalKey<core::cell::Cell<tokio::coop::Budget> >::with<core::cell::Cell<tokio::coop::Budget>,tokio::coop::with_budget::closure_env$0<enum2$<core::result::Result<alloc::boxed::Box<tokio::runtime::thread_pool::worker::Core,alloc::alloc::
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\thread\local.rs:421
  98: tokio::coop::with_budget
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\coop.rs:95
  99: tokio::coop::budget
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\coop.rs:72
 100: tokio::runtime::thread_pool::worker::Context::run_task
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\thread_pool\worker.rs:434
 101: tokio::runtime::thread_pool::worker::Context::run
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\thread_pool\worker.rs:401
 102: tokio::runtime::thread_pool::worker::run::closure$0
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\thread_pool\worker.rs:386
 103: tokio::macros::scoped_tls::ScopedKey<tokio::runtime::thread_pool::worker::Context>::set<tokio::runtime::thread_pool::worker::Context,tokio::runtime::thread_pool::worker::run::closure_env$0,tuple$<> >
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\macros\scoped_tls.rs:61
 104: tokio::runtime::thread_pool::worker::run
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\thread_pool\worker.rs:383
 105: tokio::runtime::thread_pool::worker::impl$0::launch::closure$0
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\thread_pool\worker.rs:362
 106: tokio::runtime::blocking::task::impl$2::poll<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0,tuple$<> >
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\blocking\task.rs:42
 107: tokio::runtime::task::core::impl$3::poll::closure$0<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0> >
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\core.rs:165
 108: tokio::loom::std::unsafe_cell::UnsafeCell<enum2$<tokio::runtime::task::core::Stage<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0> > > >::with_mut<enum2$<tokio::runtime::task::core::Stage<to
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\loom\std\unsafe_cell.rs:14
 109: tokio::runtime::task::core::CoreStage<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0> >::poll<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\core.rs:155
 110: tokio::runtime::task::harness::poll_future::closure$0<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0>,tokio::runtime::blocking::schedule::NoopSchedule>
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\harness.rs:480
 111: core::panic::unwind_safe::impl$23::call_once<enum2$<core::task::poll::Poll<tuple$<> > >,tokio::runtime::task::harness::poll_future::closure_env$0<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\panic\unwind_safe.rs:271
 112: std::panicking::try::do_call<core::panic::unwind_safe::AssertUnwindSafe<tokio::runtime::task::harness::poll_future::closure_env$0<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0>,tokio::runti
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panicking.rs:492
 113: std::panicking::try::do_catch<core::panic::unwind_safe::AssertUnwindSafe<tokio::runtime::task::harness::cancel_task::closure_env$0<tokio::runtime::blocking::task::BlockingTask<tokio::io::blocking::impl$1::poll_flush::closure_env$0<std::io::stdio::Stdout> 
 114: std::panicking::try<enum2$<core::task::poll::Poll<tuple$<> > >,core::panic::unwind_safe::AssertUnwindSafe<tokio::runtime::task::harness::poll_future::closure_env$0<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::l
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panicking.rs:456
 115: std::panic::catch_unwind<core::panic::unwind_safe::AssertUnwindSafe<tokio::runtime::task::harness::poll_future::closure_env$0<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0>,tokio::runtime::
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panic.rs:137
 116: tokio::runtime::task::harness::poll_future<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0>,tokio::runtime::blocking::schedule::NoopSchedule>
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\harness.rs:468
 117: tokio::runtime::task::harness::Harness<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0>,tokio::runtime::blocking::schedule::NoopSchedule>::poll_inner<tokio::runtime::blocking::task::BlockingT
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\harness.rs:104
 118: tokio::runtime::task::harness::Harness<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0>,tokio::runtime::blocking::schedule::NoopSchedule>::poll<tokio::runtime::blocking::task::BlockingTask<to
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\harness.rs:57
 119: tokio::runtime::task::raw::poll<tokio::runtime::blocking::task::BlockingTask<tokio::runtime::thread_pool::worker::impl$0::launch::closure_env$0>,tokio::runtime::blocking::schedule::NoopSchedule>
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\raw.rs:144
 120: tokio::runtime::task::raw::RawTask::poll
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\raw.rs:84
 121: tokio::runtime::task::UnownedTask<tokio::runtime::blocking::schedule::NoopSchedule>::run<tokio::runtime::blocking::schedule::NoopSchedule>
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\task\mod.rs:418
 122: tokio::runtime::blocking::pool::Task::run
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\blocking\pool.rs:91
 123: tokio::runtime::blocking::pool::Inner::run
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\blocking\pool.rs:325
 124: tokio::runtime::blocking::pool::impl$4::spawn_thread::closure$0
             at C:\Users\xunil\.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.20.1\src\runtime\blocking\pool.rs:300
 125: std::sys_common::backtrace::__rust_begin_short_backtrace<tokio::runtime::blocking::pool::impl$4::spawn_thread::closure_env$0,tuple$<> >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\sys_common\backtrace.rs:122
 126: std::sys_common::backtrace::__rust_begin_short_backtrace<tokio::runtime::blocking::pool::impl$4::spawn_thread::closure_env$0,tuple$<> >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\sys_common\backtrace.rs:122
 127: std::thread::impl$0::spawn_unchecked_::closure$1::closure$0<tokio::runtime::blocking::pool::impl$4::spawn_thread::closure_env$0,tuple$<> >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\thread\mod.rs:514
 128: core::panic::unwind_safe::impl$23::call_once<tuple$<>,std::thread::impl$0::spawn_unchecked_::closure$1::closure_env$0<tokio::runtime::blocking::pool::impl$4::spawn_thread::closure_env$0,tuple$<> > >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\panic\unwind_safe.rs:271
 129: std::panicking::try::do_call<core::panic::unwind_safe::AssertUnwindSafe<std::thread::impl$0::spawn_unchecked_::closure$1::closure_env$0<tokio::runtime::blocking::pool::impl$4::spawn_thread::closure_env$0,tuple$<> > >,tuple$<> >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panicking.rs:492
 130: std::panicking::try::do_catch<core::panic::unwind_safe::AssertUnwindSafe<tokio::runtime::task::harness::cancel_task::closure_env$0<tokio::runtime::blocking::task::BlockingTask<tokio::io::blocking::impl$1::poll_flush::closure_env$0<std::io::stdio::Stdout> 
 131: std::panicking::try<tuple$<>,core::panic::unwind_safe::AssertUnwindSafe<std::thread::impl$0::spawn_unchecked_::closure$1::closure_env$0<tokio::runtime::blocking::pool::impl$4::spawn_thread::closure_env$0,tuple$<> > > >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panicking.rs:456
 132: std::panic::catch_unwind<core::panic::unwind_safe::AssertUnwindSafe<std::thread::impl$0::spawn_unchecked_::closure$1::closure_env$0<tokio::runtime::blocking::pool::impl$4::spawn_thread::closure_env$0,tuple$<> > >,tuple$<> >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\panic.rs:137
 133: std::thread::impl$0::spawn_unchecked_::closure$1<tokio::runtime::blocking::pool::impl$4::spawn_thread::closure_env$0,tuple$<> >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\std\src\thread\mod.rs:513
 134: core::ops::function::FnOnce::call_once<std::thread::impl$0::spawn_unchecked_::closure_env$1<tokio::runtime::blocking::pool::impl$4::spawn_thread::closure_env$0,tuple$<> >,tuple$<> >
             at /rustc/897e37553bba8b42751c67658967889d11ecd120\library\core\src\ops\function.rs:248
 135: alloc::boxed::impl$44::call_once
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\alloc\src\boxed.rs:1940
 136: alloc::boxed::impl$44::call_once
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\alloc\src\boxed.rs:1940
 137: std::sys::windows::thread::impl$0::new::thread_start
             at /rustc/897e37553bba8b42751c67658967889d11ecd120/library\std\src\sys\windows\thread.rs:56
 138: BaseThreadInitThunk
 139: RtlUserThreadStart

@xunilrj xunilrj requested a review from a team November 15, 2022 13:07
@netlify
Copy link

netlify bot commented Nov 15, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit 0e76144
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637e05b12d2891000846d376
😎 Deploy Preview https://deploy-preview-3740--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

leops
leops reviewed Nov 15, 2022
View reviewed changes
crates/rome_cli/src/termination.rs Outdated
@@ -76,6 +76,9 @@ pub enum Termination {

#[error("The combination of configuration and arguments is invalid: \n {0}")]
IncompatibleEndConfiguration(&'static str),

#[error("no supported files were found in the specified folders.")]
ZeroSupportedFilesFound,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was accidentally included from #3722

crates/rome_diagnostics/src/v2/mod.rs Outdated Show resolved Hide resolved
@xunilrj xunilrj force-pushed the fix/lsp-friendly-catch-unwind branch from e8f669f to 6da7eb5 Compare November 15, 2022 16:07
@xunilrj xunilrj mentioned this pull request Nov 17, 2022
Merged
@xunilrj xunilrj force-pushed the fix/lsp-friendly-catch-unwind branch from 306db96 to 0e76144 Compare November 23, 2022 11:36
@xunilrj xunilrj merged commit bc942f0 into main Nov 23, 2022
@xunilrj xunilrj deleted the fix/lsp-friendly-catch-unwind branch November 23, 2022 11:48
jeysal added a commit to jeysal/rometools that referenced this pull request Nov 24, 2022
@jeysal
Merge remote-tracking branch 'upstream/main' into integr-docs
0ac7801 
* upstream/main: (73 commits)
  fix(semantic_analyzers): style/noShoutyConstants does not recognize multiple uses of a constant. (rome#3789)
  feat(rome_js_analyze): useDefaultSwitchClauseLast (rome#3791)
  chore: run rustfmt and typo fix (rome#3840)
  feat(rome_js_analyze): use exhaustive deps support properties (rome#3581)
  website(docs): Fix text formatting (rome#3828)
  feat(rome_js_analyze): `noVoidTypeReturn` (rome#3806)
  feat(rome_cli): expose the `--verbose` flag to the CLI (rome#3812)
  fix(rome_diagnostics): allow diagnostic locations to be created without a resource (rome#3834)
  feat(rome_js_analyze): add noExtraNonNullAssertion rule (rome#3797)
  fix(rome_lsp): lsp friendly catch unwind (rome#3740)
  feat(rome_js_semantic): model improvements (rome#3825)
  feat(rome_json_parser): JSON Lexer (rome#3809)
  feat(rome_js_analyze): implement `noDistractingElements` (rome#3820)
  fix(rome_js_formatter): shothanded named import line break with default import (rome#3826)
  feat(rome_js_analyze): `noConstructorReturn` (rome#3805)
  feat(website): change enabledNurseryRules to All/Recommended select (rome#3810)
  feat(rome_js_analyze): noSetterReturn
  feat(rome_js_analyze): noConstructorReturn
  feat(rome_analyze): suppress rule via code actions (rome#3572)
  feat(rome_js_analyze): `noVar` (rome#3765)
  ...
@MichaReiser MichaReiser mentioned this pull request Nov 24, 2022
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leops leops leops left review comments

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xunilrj @ematipico @leops