This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): inline variable considering initializer #3777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3697.
Better together with #3740.
This PR increments the code action "inline variable" considering the type of the initializer.
There is a chance that we may want to revisit this in the future, because some expressions do not make sense to be inlined. Example:
Don't know why someone would write this, but this sure do not make sense to be inlined.
Test Plan