[v624] gcc12's regex header file relies on a std::vector<int> instance, expo… #11574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt it. The C++ modules marks the std::vector<int> instantiation as not visible because it came from the `regex` header file which we did not explicitly include. root-project/root@a785402 introduces checks if certain declaration is visible in dictionary generation time which was intending to semantically improve the coherence by what the user "allowed" (or requested) rootcling to see vs what it can see globally. While this model works well it seems to not work for template instantiations as they won't be re-instantiated with visible modifier. This patch works around the current issue seen with libstdc++ 12 but a better solution would be to implement a finer grained control over the implicit template instatiations when generating a dictionary. Fixes root-project#11329
|
Starting build on |
|
Build failed on windows10/cxx14. Errors:
And 9 more |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
Axel-Naumann
approved these changes
Oct 17, 2022
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on mac12/noimt. Errors:
|
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Failing tests: |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests: |
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on mac12/noimt. Errors:
|
|
Build failed on windows10/cxx14. Errors:
And 126 more |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Failing tests: |
|
Build failed on ROOT-ubuntu2004/python3. Failing tests:
|
|
@Axel-Naumann, what should we do - these failures seem unrelated... |
guitargeek
changed the title
|
will we merge this PR now that v632 is approaching? |
|
I have not seen complaints and we are far ahead in releases. Let’s not bother. |
|
I close it following @vgvassilev 's observation, feel free to re-open if this becomes a problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rt it.
The C++ modules marks the std::vector instantiation as not visible because it came from the
regexheader file which we did not explicitly include.a785402 introduces checks if certain declaration is visible in dictionary generation time which was intending to semantically improve the coherence by what the user "allowed" (or requested) rootcling to see vs what it can see globally. While this model works well it seems to not work for template instantiations as they won't be re-instantiated with visible modifier.
This patch works around the current issue seen with libstdc++ 12 but a better solution would be to implement a finer grained control over the implicit template instatiations when generating a dictionary.
Fixes #11329