Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v624] gcc12's regex header file relies on a std::vector<int> instance, expo… #11574

Commits on Oct 15, 2022

  1. gcc12's regex header file relies on a std::vector<int> instance, expo…

    …rt it.
    
    The C++ modules marks the std::vector<int> instantiation as not visible because
    it came from the `regex` header file which we did not explicitly include.
    
    root-project/root@a785402 introduces checks if certain declaration is visible
    in dictionary generation time which was intending to semantically improve the
    coherence by what the user "allowed" (or requested) rootcling to see vs what
    it can see globally. While this model works well it seems to not work for
    template instantiations as they won't be re-instantiated with visible modifier.
    
    This patch works around the current issue seen with libstdc++ 12 but a better
    solution would be to implement a finer grained control over the implicit template
    instatiations when generating a dictionary.
    
    Fixes root-project#11329
    vgvassilev committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    645da3d View commit details
    Browse the repository at this point in the history