Install WP-CLI packages #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
fullyint
reviewed
Jun 12, 2017
roles/wp-cli/tasks/main.yml
Outdated
| @@ -23,3 +23,10 @@ | |||
| warn: false | |||
| register: wp_cli_completion | |||
| changed_when: wp_cli_completion.stdout == 'wp-completion-' + wp_cli_version + '.bash' | |||
|
|
|||
| - name: Install WP-CLI packages | |||
| command: "wp package install {{ item }}" | |||
There was a problem hiding this comment.
nitpick: double quotes are only necessary if the {{ jinja }} begins the variable value, so this could just be
- command: "wp package install {{ item }}"
+ command: wp package install {{ item }}I realize Trellis is not always consistent on this, but the general goal has been to use quotes only when absolutely needed.
roles/wp-cli/tasks/main.yml
Outdated
| command: "wp package install {{ item }}" | ||
| become_user: "{{ web_user }}" | ||
| register: wp_cli_packages_installed | ||
| changed_when: "'Nothing to install or update' not in wp_cli_packages_installed.stdout" |
There was a problem hiding this comment.
While testing, I noticed that in some cases stdout for already-installed packages did not include 'Nothing to install or update' but instead included 'Package operations: 0 installs, 0 updates, 0 removals'. This meant that sometimes Ansible inaccurately reported changed for packages that were already installed.
How does this modification look to you?
- changed_when: "'Nothing to install or update' not in wp_cli_packages_installed.stdout"
+ changed_when:
+ - "'Nothing to install or update' not in wp_cli_packages_installed.stdout"
+ - "'Package operations: 0 installs, 0 updates, 0 removals' not in wp_cli_packages_installed.stdout"I would have preferred to be more concise by checking for a string that is unique to when packages are freshly installed but I didn't observe any such string.
fullyint
force-pushed
the
wp-cli-packages
branch
from
09ecc9a
to
77d00cd
Compare
|
thank you! |
primozcigler
added a commit
to primozcigler/trellis
that referenced
this pull request
Jun 26, 2017
* master: (120 commits) Reload Nginx with updates to manual cert or key (roots#843) Add self signed certificates subdomains (roots#812) Add support for SMTP without authentication Remove output about running WP-CLI and Composer Option to install WP-CLI packages (roots#837) Update WP theme paths only when template_root in releases_path (roots#840) Update wp-cli to 1.2.1 (roots#838) skip plugins with WP-CLI, to avoid crappy plugins breaking deploys Add options for sources and version Add re-run vagrant up message Remove plugins from README Auto-install Vagrant plugins Fixes Add Vagrant config support Use python slice on password salt instead of Jinja2 truncate() Avoid single var containing jinja delimiters in when parameter Remove jinja delimiters from tasks' when parameter Update connection test for new dense.py callback in Ansible 2.3 Deploys: Make wp core update-db optional (roots#827) Use a block ... # Conflicts: # Vagrantfile # ansible.cfg
skemantix
pushed a commit
to skemantix/trellis
that referenced
this pull request
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.