Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload Nginx with updates to manual cert or key #843

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

fullyint
Copy link
Contributor

When a user updates the manual SSL cert, the copy module will copy the new cert (default force: yes) but the new cert won't take effect unless Nginx reloads.

This PR ensures Nginx reloads if the "manual" cert or key changes.

Copy link
Member

@swalkinshaw swalkinshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fullyint fullyint merged commit 456bb83 into master Jun 23, 2017
@fullyint fullyint deleted the reload-nginx-if-new-manual-cert branch June 23, 2017 00:25
primozcigler added a commit to primozcigler/trellis that referenced this pull request Jun 26, 2017
* master: (120 commits)
  Reload Nginx with updates to manual cert or key (roots#843)
  Add self signed certificates subdomains (roots#812)
  Add support for SMTP without authentication
  Remove output about running WP-CLI and Composer
  Option to install WP-CLI packages (roots#837)
  Update WP theme paths only when template_root in releases_path (roots#840)
  Update wp-cli to 1.2.1 (roots#838)
  skip plugins with WP-CLI, to avoid crappy plugins breaking deploys
  Add options for sources and version
  Add re-run vagrant up message
  Remove plugins from README
  Auto-install Vagrant plugins
  Fixes
  Add Vagrant config support
  Use python slice on password salt instead of Jinja2 truncate()
  Avoid single var containing jinja delimiters in when parameter
  Remove jinja delimiters from tasks' when parameter
  Update connection test for new dense.py callback in Ansible 2.3
  Deploys: Make wp core update-db optional (roots#827)
  Use a block
  ...

# Conflicts:
#	Vagrantfile
#	ansible.cfg
skemantix pushed a commit to skemantix/trellis that referenced this pull request Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants