-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more common hardware interface type constants #1500
Add more common hardware interface type constants #1500
Conversation
hardware_interface/include/hardware_interface/types/hardware_interface_type_values.hpp
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1500 +/- ##
=======================================
Coverage 62.67% 62.67%
=======================================
Files 96 96
Lines 11311 11311
Branches 8151 8151
=======================================
Hits 7089 7089
Misses 715 715
Partials 3507 3507
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. would you then change the gazebo plugin to allow using force/torque for prismatic/revolute joints?
I'm not entirely sure at this part, then it means we have to update the ros2_controllers to have a parameter to accept the effort type, and by default it stays with the EFFORT and users can configure it. This would be the next task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hardware_interface/include/hardware_interface/types/hardware_interface_type_values.hpp
Show resolved
Hide resolved
Hello @olivier-stasse! I've just added them as per your request 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!! (after removing absolute position!)
hardware_interface/include/hardware_interface/types/hardware_interface_type_values.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Dr. Denis <[email protected]>
hardware_interface/include/hardware_interface/types/hardware_interface_type_values.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grand!
This is to add more sets of more common hardware interface type constants that are used day-to-day. Defining it here would bring some standards in the naming + reusability.
Some reference : https://github.com/ros-controls/ros_control/blob/noetic-devel/hardware_interface/include/hardware_interface/joint_state_interface.h