Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more common hardware interface type constants #1500

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Apr 23, 2024

This is to add more sets of more common hardware interface type constants that are used day-to-day. Defining it here would bring some standards in the naming + reusability.

Some reference : https://github.com/ros-controls/ros_control/blob/noetic-devel/hardware_interface/include/hardware_interface/joint_state_interface.h

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.67%. Comparing base (16fbde3) to head (d17b4be).

❗ Current head d17b4be differs from pull request most recent head c898bd2. Consider uploading reports for the commit c898bd2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   62.67%   62.67%           
=======================================
  Files          96       96           
  Lines       11311    11311           
  Branches     8151     8151           
=======================================
  Hits         7089     7089           
  Misses        715      715           
  Partials     3507     3507           
Flag Coverage Δ
unittests 62.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. would you then change the gazebo plugin to allow using force/torque for prismatic/revolute joints?

@saikishor
Copy link
Member Author

LGTM. would you then change the gazebo plugin to allow using force/torque for prismatic/revolute joints?

I'm not entirely sure at this part, then it means we have to update the ros2_controllers to have a parameter to accept the effort type, and by default it stays with the EFFORT and users can configure it. This would be the next task

Copy link
Contributor

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikishor
Copy link
Member Author

Hello @olivier-stasse!

I've just added them as per your request 👍

destogl
destogl previously approved these changes Apr 24, 2024
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! (after removing absolute position!)

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grand!

@bmagyar bmagyar merged commit 0112083 into ros-controls:master May 4, 2024
9 of 11 checks passed
@saikishor saikishor deleted the add/more_interface_type_constants branch August 17, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants