rqt_cm: Fix handling of unconfigured controllers during spawn action #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
christophfroehlich,
DasRoteSkelett,
destogl,
fmauch,
mcbed and
olivier-stasse
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1794 +/- ##
==========================================
+ Coverage 86.83% 86.86% +0.02%
==========================================
Files 121 121
Lines 11542 11541 -1
Branches 1054 1054
==========================================
+ Hits 10023 10025 +2
+ Misses 1144 1142 -2
+ Partials 375 374 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
christophfroehlich
changed the title
christophfroehlich
approved these changes
Oct 14, 2024
8 tasks
christophfroehlich
added
backport-humble
|
Thanks, @christophfroehlich , for your support. I kept the PR in draft because I wasn’t able to perform proper testing. I thought some code changes might be needed based on the results, which is why I left it as a draft. |
|
I believe, everything went fine. So I change PR back to |
github-actions
bot
requested review from
arne48,
christophfroehlich,
erickisos and
progtologist
christophfroehlich
approved these changes
Oct 14, 2024
|
@christophfroehlich Please let me know if there any further changes needed for this PR? |
bmagyar
approved these changes
Oct 15, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 16, 2024
…ontroller (#1794) (#1797) (cherry picked from commit 0ba1428) Co-authored-by: Santosh Govindaraj <[email protected]>
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 16, 2024
…ontroller (#1794) (#1798) (cherry picked from commit 0ba1428) Co-authored-by: Santosh Govindaraj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses an #1791 issue where controllers in the "unconfigured" state were being loaded rather than configured during the action_spawn process. The previous behavior could lead to errors when attempting to activate controllers that were not yet configured.
Changes made:
Testing:
I was unable to test the changes with
diffbot.launch.pydue to build issues withros2_controllerson my system running ROS Iron, as therollingbuild is not compatible withiron.