Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full functionality of chainable controllers #667
Full functionality of chainable controllers #667
Changes from all commits
d19c724
03ae2b2
c5d7383
862987e
0b7bd7f
2a4af6b
44b17e0
b0cc0a7
f883120
0a46e6c
1b16a1b
50fee31
a3f928d
a0b64da
1b05bf2
5d7b040
fac6a89
a2be1d1
0348e8d
ed0d8d6
648d039
65bcd7c
cad977b
1cb9154
b0ff012
d652a34
8ead608
4b81f80
fe20955
702f69f
e6d2f23
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
umm... were moved here for testability? can we have them in a
protected
section instead perhaps?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a
protected
section. Yes, I moved it for simpler testing, otherwise doesn't work, or didn't come with a simple solution to do so.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why we moved things to
protected
and use a "TestableX` class wrapper or friend to write the tests where you can define a getter for these functions and do you assertionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again: those members are
protected
or am I seeing something wrong?