Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional axes initial value parameter to handle the trigger behavior #214

Closed
wants to merge 1 commit into from

Conversation

jlack1987
Copy link

Potential fix for #155. I think the right way to fix it is to treat the triggers separately from the axes and to put them in different parts of the message, but I understand there's a lot of inertia here and that would cause a big ripple. I simply added an optional vector of doubles that represent initial axis values on startup.

@JWhitleyWork
Copy link

CI passing depends on #218

@peci1
Copy link
Contributor

peci1 commented Oct 27, 2021

I think this is not needed. The issue this PR tries to fix has already been fixed in #98 resp. #107. There is an already closed issue on this topic: #91.

The fix is, however, not enabled by default. To make use of it, set default_trig_val to true for joy_node.

@jlack1987 jlack1987 closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants