Adds sticky buttons functionality to joy_node. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buttons change state only when a pressed event is detected. For example button A has not been pressed so it has state 0. Now the button A is pressed assuming state 1. On release of the button the sticky buttons implementation leaves the state of the button at 1. To Change state back to 0 another button press event for button A has to be registered. This functionality can be useful when steering a state machine (or other event driven object) over the network via the joystick, as the press of a joystick button causes a step in the button signal and not an impulse of indederminate length which could be more diffucult to parse into an event.
|
We've typically implemented this functionality at a higher-level teleop node, but I'm not opposed to it going into joy_node. Some other feedback:
@jbohren would have to decide about merging; probably no point addressing this stuff without his blessing. |
|
Fixed by #107, using |
|
This feature seems nice but the Wiki page was not modified to reflect that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons change state only when a pressed event is detected. For example button A has not been pressed so it has state 0. Now the button A is pressed assuming state 1. On release of the button the sticky buttons implementation leaves the state of the button at 1. To Change state back to 0 another button press event for button A has to be registered.
This functionality can be useful when steering a state machine (or other event driven object) over the network via the joystick, as the press of a joystick button causes a step in the button signal and not an impulse of indederminate length which could be more diffucult to parse into an event.