Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to latest rw #32

Merged
merged 4 commits into from
Feb 21, 2019

Conversation

jontje
Copy link
Contributor

@jontje jontje commented Feb 20, 2019

  • Handles the latest EGM communication protocol
  • Reworked the sample time estimation

Solves issue #19

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments.

include/abb_libegm/egm_common.h Show resolved Hide resolved
proto/egm.proto Show resolved Hide resolved
proto/egm.proto Show resolved Hide resolved
proto/egm.proto Show resolved Hide resolved
proto/egm.proto Show resolved Hide resolved
proto/egm.proto Show resolved Hide resolved
proto/egm_wrapper.proto Outdated Show resolved Hide resolved
src/egm_base_interface.cpp Show resolved Hide resolved
src/egm_common.cpp Outdated Show resolved Hide resolved
gavanderhoorn
gavanderhoorn previously approved these changes Feb 21, 2019
@gavanderhoorn
Copy link
Member

This one could also use a rebase.

@jontje
Copy link
Contributor Author

jontje commented Feb 21, 2019

I have rebased the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants