Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing urdf dependency to nav2_rviz_plugins package #4050

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Add missing urdf dependency to nav2_rviz_plugins package #4050

merged 1 commit into from
Jan 14, 2024

Conversation

doisyg
Copy link
Contributor

@doisyg doisyg commented Jan 14, 2024

Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu
Robotic platform tested on Dexory build env
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Add dependency tag to urdf in nav2_rviz_plugins package.
It is only problematic when building from source along urdf.

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

missing urdf dep
e22b6f9 
Signed-off-by: Guillaume Doisy <[email protected]>
@SteveMacenski SteveMacenski merged commit a8a0c3a into ros-navigation:main Jan 14, 2024
7 of 9 checks passed
SteveMacenski pushed a commit that referenced this pull request Jan 24, 2024
@doisyg @SteveMacenski
missing urdf dep (#4050)
347a0f5 
Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
SteveMacenski added a commit that referenced this pull request Jan 24, 2024
@SteveMacenski @thandal
@antonkesy @CihatAltiparmak @akchobby @Plaqueoff @kfabian @ladianchad @kevin-floatic @doisyg @romi2002 @mikeferguson @Hao-Li-Bachelorarbeit @GoesM @BriceRenaudeau @jwallace42 @Sunart24 @renan028
Iron Sync 4: Jan 23, 2024 (#4063)
57093ec 
* collision_monitor: dynamic polygon and source enable/disable (#3825)

* Rename PushRosNamespace to PushROSNamespace

* Fix min_points checking

* initial

* fix

* fix

* remove unrelated change

* reset

* fix format

* PR fixes

* Add test

* fix comments

* add to params

* publish only if enabled

* Add source dynamic enable/disable

* add enabled param to sources

* fix

* add same to collision detector

* Update README.md: fix typo (#3842)

* Update package.xml

* fix typo (#3850)

* adjust link to point to v3.8 of behavior tree docs (#3851)

BT.CPP_v3 is used, thereby the correct docs should be linked

* Fix bug in nav2_behavior_tree/bt_action_node (#3849)

* Fix bug in nav2_behavior_tree/bt_action_node

* Fixed the bug in halt function inside
  nav2_behavior_tree/plugin/action/bt_action_node.hpp

* Added new case to nav2_behavior_tree/plugin/action/bt_action_node.hpp
  for testing the scenario to cancel

* Refactored existing cases in
  nav2_behavior_tree/plugin/action/bt_action_node.hpp

Signed-off-by: CihatAltiparmak <[email protected]>

* Fix bug in nav2_behavior_tree/bt_action_node

* Fixed the bug in halt function inside
  nav2_behavior_tree/plugin/action/bt_action_node.hpp

* Added new case to nav2_behavior_tree/plugin/action/bt_action_node.hpp
  for testing the scenario to cancel

* Refactored existing cases in
  nav2_behavior_tree/plugin/action/bt_action_node.hpp

Signed-off-by: CihatAltiparmak <[email protected]>

---------

Signed-off-by: CihatAltiparmak <[email protected]>

* Fix action test failure due to rate after Rolling sync API change (#3852)

* Update CMakeLists.txt (#3843)

* add option for sse4 and avs512 (#3853)

* Remove all exit(-1) crash conditions (#3846)

* Update transform_available_condition.cpp

* wrapping all examples of get_plugin_type_param in exceptions and making that throw instead of crash

* some linting

* fix typo

* Update controller.cpp

* Update nav2_params.yaml

* Update nav2_params.yaml

* simplication of lattice_generator.py, fixes #3858 (#3859)

* simplification of equation to compute the max_value/outer edge of the lattice based on number of headings.

* Stop error diagnostics when pausing nav (#3830)

* Added nodestate enum and a variable to keep track of current state of managed nodes.

* Updating state_of_managed_nodes_ when switching states and using it to determine an accurate diagnostics message.

* Fixing bugs.

* Updated/added docstrings.

* Publishing OK status when nodes are unconfigured. Changed if-else chain to switch case.

* Renamed NodeState PAUSED to INACTIVE, state_of_managed_nodes_ to managed_nodes_state_ and replaced system_active_ with an inline method.

* Bugfix.

---------

Co-authored-by: Pekka Myller <[email protected]>

* Add a timeout to the wait for transforms step of the costmap activation. (#3866)

* Add a timeout to the wait for transforms step of the costmap activation.

Signed-off-by: Fabian König <[email protected]>

* Rename wait_for_transforms_timeout to initial_transform_timeout

* Activate costmap publishers only after transforms are checked

* Check if controller server activation was succesful in planner_server

* Add unittest for costmap activation

Signed-off-by: Fabian König <[email protected]>

---------

Signed-off-by: Fabian König <[email protected]>

* Fix class doxygen

* fix minor typos (#3892)

Signed-off-by: Anton Kesy <[email protected]>

* Publish collision points for debug purposes (#3879)

* Rename PushRosNamespace to PushROSNamespace

* Fix min_points checking

* .

* fixes

* add to collision detector

* fix

* fix

* .

* fixes

* add namespace to topic

* fixes

* fix use after free (#3910)

* fix build mppi (#3927)

Signed-off-by: kevin <[email protected]>
Co-authored-by: kevin <[email protected]>

* Removing old TODOs

* protect invalid max_velocity min_velocity (#3953)

Co-authored-by: Guillaume Doisy <[email protected]>

* protect properly max_accel and max_decel (#3952)

Co-authored-by: Guillaume Doisy <[email protected]>

* Fixed links for install and build in README (#3963)

Currently the readme is linking to an invalida page in the docs (404 error).

* adding support for rotate in place cusps (#3934)

* Fix linting error (#3969)

* Fix linting error

* Update regulated_pure_pursuit_controller.cpp

* fix a few outdated comments in smac planners (#3978)

* adding soft realtime prioritization for collision monitor and velocity smoother (#3979)

* adding soft realtime prioritization for collision monitor and velocity smoother

* refactor simple action server to use new utils API

* Update README.md

* Synchronize map size information during map initialization (#4015)

* Update costmap size configuration

This commit updates the costmap_2d.cpp file to fix a bug where the costmap size wasn't appropriately updated. Two new lines of code have been added to ensure the size of the costmap is correctly configured each time it's instantiated.

* Refactor costmap size assignment in Costmap2D class

The code refactor eliminates the direct mutation of the size_x_ and size_y_ attributes in the Costmap2D class. Instead, the class uses the size of cells provided during initialization and calculation from map coordinates for better encapsulation and clarity.

* check width&height params (#4017)

Co-authored-by: GoesM <[email protected]>

* Fix SimpleActionServer nullprt callback (#4025)

* add check before calling completion_callback_

* Fix lint

* footprint checks (#4030)

* footprint checks

Signed-off-by: gg <[email protected]>

* lint fix

Signed-off-by: gg <[email protected]>

---------

Signed-off-by: gg <[email protected]>

* Is path valid doc (#4032)

* docs

Signed-off-by: gg <[email protected]>

* update

Signed-off-by: gg <[email protected]>

---------

Signed-off-by: gg <[email protected]>

* Update vision_opencv's branch for rolling

Signed-off-by: Steve Macenski <[email protected]>

* handle dynamically changes in parameters. (#4046)

Signed-off-by: Sebastian Solarte <[email protected]>

* Add inflation_layer_name param (#4047)

Signed-off-by: Renan Salles <[email protected]>

* missing urdf dep (#4050)

Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>

* bump to 1.2.6 for release

---------

Signed-off-by: CihatAltiparmak <[email protected]>
Signed-off-by: Fabian König <[email protected]>
Signed-off-by: Anton Kesy <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: gg <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Sebastian Solarte <[email protected]>
Signed-off-by: Renan Salles <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Tony Najjar <[email protected]>
Co-authored-by: thandal <[email protected]>
Co-authored-by: Anton Kesy <[email protected]>
Co-authored-by: CihatAltiparmak <[email protected]>
Co-authored-by: Anil Kumar Chavali <[email protected]>
Co-authored-by: Plaqueoff <[email protected]>
Co-authored-by: Pekka Myller <[email protected]>
Co-authored-by: Fabian König <[email protected]>
Co-authored-by: 정찬희 <[email protected]>
Co-authored-by: kevin <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Abiel Fernandez <[email protected]>
Co-authored-by: Michael Ferguson <[email protected]>
Co-authored-by: Hao-Li-Bachelorarbeit <[email protected]>
Co-authored-by: GoesM <[email protected]>
Co-authored-by: GoesM <[email protected]>
Co-authored-by: BriceRenaudeau <[email protected]>
Co-authored-by: Joshua Wallace <[email protected]>
Co-authored-by: Sebastian Solarte <[email protected]>
Co-authored-by: Renan Salles <[email protected]>
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
@doisyg @enricosutera
missing urdf dep (ros-navigation#4050)
e7bcf6d 
Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Signed-off-by: enricosutera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doisyg @SteveMacenski