Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated player QoS #164

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Updated player QoS #164

merged 5 commits into from
Aug 22, 2024

Conversation

ahcorde
Copy link

@ahcorde ahcorde commented May 13, 2024

Related to this PR in rosbag2_py which allow to instrospect QoS of rosbag topics ros2/rosbag2#1648

The PR on rosbag is on hold because of this comment ros2/rosbag2#1648 (comment)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this May 13, 2024
@ahcorde ahcorde marked this pull request as ready for review August 21, 2024 10:49
@ahcorde
Copy link
Author

ahcorde commented Aug 21, 2024

@clalancette required PR is merged on rosbag2. This PR is ready

@ahcorde ahcorde requested a review from mjcarroll August 22, 2024 11:43
Copy link

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with CI

@ahcorde
Copy link
Author

ahcorde commented Aug 22, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 4a9a696 into rolling Aug 22, 2024
1 check passed
@ahcorde
Copy link
Author

ahcorde commented Aug 22, 2024

https://github.com/Mergifyio backport jazzy

@ahcorde ahcorde deleted the ahcorde/rolling/player_qos branch August 22, 2024 14:14
Copy link

mergify bot commented Aug 22, 2024

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 22, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 4a9a696)
ahcorde added a commit that referenced this pull request Aug 23, 2024
Updated player QoS (#164)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 4a9a696)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Trana pushed a commit to Trana/rqt_bag that referenced this pull request Aug 28, 2024
…n#167)

Updated player QoS (ros-visualization#164)

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 4a9a696)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants