-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated player QoS #164
Merged
Merged
Updated player QoS #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@clalancette required PR is merged on rosbag2. This PR is ready |
mjcarroll
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with CI
clalancette
approved these changes
Aug 22, 2024
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 4a9a696)
ahcorde
added a commit
that referenced
this pull request
Aug 23, 2024
Updated player QoS (#164) Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 4a9a696) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Trana
pushed a commit
to Trana/rqt_bag
that referenced
this pull request
Aug 28, 2024
…n#167) Updated player QoS (ros-visualization#164) Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 4a9a696) Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR in rosbag2_py which allow to instrospect QoS of rosbag topics ros2/rosbag2#1648
The PR on rosbag is on hold because of this comment ros2/rosbag2#1648 (comment)