sophus: fails in do_compile on x86-64 architecture

[bulwahn]

bitbake sophus fails during compiling with:

[...]
| /home/lukas/work/repositories/openembedded.org/openembedded-core/build/tmp-glibc/work/core2-64-oe-linux/sophus/0.9.1-r0/recipe-sysroot/usr/include/eigen3/Eigen/src/Core/Matrix.h:311:7:   required from 'Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols>::Matrix(const Eigen::ReturnByValue<OtherDerived>&) [with OtherDerived = Eigen::MatrixExponentialReturnValue<Eigen::Matrix<float, 4, 4> >; _Scalar = float; int _Rows = 4; int _Cols = 4; int _Options = 0; int _MaxRows = 4; int _MaxCols = 4]'
| /home/lukas/work/repositories/openembedded.org/openembedded-core/build/tmp-glibc/work/core2-64-oe-linux/sophus/0.9.1-r0/sophus-0.9.1/sophus/tests.hpp:96:64:   required from 'bool Sophus::Tests<LieGroup>::expMapTest() [with LieGroup = Sophus::Sim3Group<float>]'
| /home/lukas/work/repositories/openembedded.org/openembedded-core/build/tmp-glibc/work/core2-64-oe-linux/sophus/0.9.1-r0/sophus-0.9.1/sophus/tests.hpp:211:24:   required from 'void Sophus::Tests<LieGroup>::runAllTests() [with LieGroup = Sophus::Sim3Group<float>]'
| /home/lukas/work/repositories/openembedded.org/openembedded-core/build/tmp-glibc/work/core2-64-oe-linux/sophus/0.9.1-r0/sophus-0.9.1/sophus/test_sim3.cpp:97:3:   required from 'void tests() [with Scalar = float]'
| /home/lukas/work/repositories/openembedded.org/openembedded-core/build/tmp-glibc/work/core2-64-oe-linux/sophus/0.9.1-r0/sophus-0.9.1/sophus/test_sim3.cpp:107:16:   required from here
| /home/lukas/work/repositories/openembedded.org/openembedded-core/build/tmp-glibc/work/core2-64-oe-linux/sophus/0.9.1-r0/recipe-sysroot/usr/include/eigen3/Eigen/src/Core/DenseCoeffsBase.h:56:30: error: ignoring attributes on template argument 'Eigen::internal::packet_traits<float>::type {aka __vector(4) float}' [-Werror=ignored-attributes]
| ERROR: oe_runmake failed

The first build configuration I noticed the issue was:

Build Configuration:
BB_VERSION        = "1.33.4"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "ubuntu-14.04"
TARGET_SYS        = "x86_64-oe-linux"
MACHINE           = "qemux86-64"
DISTRO            = "nodistro"
DISTRO_VERSION    = "nodistro.0"
TUNE_FEATURES     = "m64 core2"
TARGET_FPU        = ""
meta              = "master:e584be78f92ee6f08f570c239698d56ac78d05f9"
meta-oe           
meta-multimedia   
meta-python       = "master:2c21aa8633e4e3538099bcc56d76ab0a594411b4"
meta-ros          = "master:f162d103a3b0fa97133fd15dd56eca34fcdf264e"

The issue however occurs since sophus' initial commit in meta-ros at 7b08f25.

[graugans]

I have an similar error when building for x86-64:

/home/chris/src/udoo-meta-freescale/build/tmp/sysroots/x86_64-linux/usr/bin/x86_64-fslc-linux/x86_64-fslc-linux-g++    -I/home/chris/src/udoo-meta-freescale/build/tmp/sysroots/udoox86/usr/include/eigen3  -m64 -march=corei7 -mtune=corei7 -mfpmath=sse -msse4.2  --sysroot=/home/chris/src/udoo-meta-freescale/build/tmp/sysroots/udoox86  -O2 -pipe -g -feliminate-unused-debug-types -fdebug-prefix-map=/home/chris/src/udoo-meta-freescale/build/tmp/work/corei7-64-fslc-linux/sophus/0.9.1-r0=/usr/src/debug/sophus/0.9.1-r0 -fdebug-prefix-map=/home/chris/src/udoo-meta-freescale/build/tmp/sysroots/x86_64-linux= -fdebug-prefix-map=/home/chris/src/udoo-meta-freescale/build/tmp/sysroots/udoox86=  -fvisibility-inlines-hidden  -m64 -march=corei7 -mtune=corei7 -mfpmath=sse -msse4.2  --sysroot=/home/chris/src/udoo-meta-freescale/build/tmp/sysroots/udoox86 -Wno-deprecated-declarations -Wno-misleading-indentation -O3 -DNDEBUG    -Wall -Werror -Wno-unused-variable                    -Wno-unused-but-set-variable -Wno-unknown-pragmas  -o CMakeFiles/test_rxso3.dir/sophus/test_rxso3.cpp.o -c /home/chris/src/udoo-meta-freescale/build/tmp/work/corei7-64-fslc-linux/sophus/0.9.1-r0/sophus-0.9.1/sophus/test_rxso3.cpp
In file included from /home/chris/src/udoo-meta-freescale/build/tmp/sysroots/udoox86/usr/include/eigen3/Eigen/Core:263:0,
                 from /home/chris/src/udoo-meta-freescale/build/tmp/sysroots/udoox86/usr/include/eigen3/unsupported/Eigen/MatrixFunctions:19,
                 from /home/chris/src/udoo-meta-freescale/build/tmp/work/corei7-64-fslc-linux/sophus/0.9.1-r0/sophus-0.9.1/sophus/test_se2.cpp:26:
/home/chris/src/udoo-meta-freescale/build/tmp/sysroots/udoox86/usr/include/eigen3/Eigen/src/Core/arch/SSE/PacketMath.h:29:39: error: ignoring attributes on template argument '__m128 {aka __vector(4) float}' [-Werror=ignored-attributes]
 template<> struct is_arithmetic<__m128>  { enum { value = true }; };
                                       ^                    ^

Looks like this is an warning what is turned to an error due to -Wall -Werror It seems there is a fix in the latest libeigen beta

[graugans]

I've fixed the issue with the following patch

diff --git a/recipes-extended/sophus/sophus_0.9.1.bb b/recipes-extended/sophus/sophus_0.9.1.bb
index 64cbc8b..406647b 100644
--- a/recipes-extended/sophus/sophus_0.9.1.bb
+++ b/recipes-extended/sophus/sophus_0.9.1.bb
@@ -14,4 +14,4 @@ S = "${WORKDIR}/sophus-${PV}"
 inherit cmake

 # CXXFLAGS are needed to compile eigen 3.3.1 headers properly
-CXXFLAGS += "-Wno-deprecated-declarations -Wno-misleading-indentation"
+CXXFLAGS += "-Wno-deprecated-declarations -Wno-misleading-indentation -Wno-ignored-attributes"

[bulwahn]

👍 Great. Just open a pull request, and I will quickly test it and then merge it. By the way, if you add (resolves #497) in the commit message, the commit is immediately linked to this issue and the issue is closed once it has been merged.