Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sophus: compile on x86-64 arch (resolves #497) #530

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

bulwahn
Copy link
Contributor

@bulwahn bulwahn commented Jul 6, 2017

This commit implements Christian Ege's suggestion in the meta-ros issue tracker to make gcc only warn on ignored template attributes.

This commit implements Christian Ege's suggestion in the meta-ros
issue tracker to make gcc only warn on ignored template attributes.

Signed-off-by: Lukas Bulwahn <[email protected]>
@bulwahn
Copy link
Contributor Author

bulwahn commented Jul 6, 2017

I have successfully built core-image-ros-world on these two build configurations:

Build Configuration:
BB_VERSION        = "1.33.4"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "ubuntu-14.04"
TARGET_SYS        = "i586-oe-linux"
MACHINE           = "qemux86"
DISTRO            = "nodistro"
DISTRO_VERSION    = "nodistro.0"
TUNE_FEATURES     = "m32 i586"
TARGET_FPU        = ""
meta              = "master:de7914954571ea8e717f56b6d6df13157b0973bc"
meta-oe           
meta-multimedia   
meta-python       = "master:bd259171ec0c2163a2c1025e1b83ae379cee96a7"
meta-ros          = "resolve-issue-#497:9d6db38f0d38822b2e89af931038f5f4cce9a470"
Build Configuration:
BB_VERSION        = "1.33.4"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "ubuntu-14.04"
TARGET_SYS        = "x86_64-oe-linux"
MACHINE           = "qemux86-64"
DISTRO            = "nodistro"
DISTRO_VERSION    = "nodistro.0"
TUNE_FEATURES     = "m64 core2"
TARGET_FPU        = ""
meta              = "master:de7914954571ea8e717f56b6d6df13157b0973bc"
meta-oe           
meta-multimedia   
meta-python       = "master:bd259171ec0c2163a2c1025e1b83ae379cee96a7"
meta-ros          = "resolve-issue-#497:9d6db38f0d38822b2e89af931038f5f4cce9a470"

@bulwahn
Copy link
Contributor Author

bulwahn commented Jul 6, 2017

@rojkov Please review, test and merge. Thanks.

@rojkov
Copy link
Contributor

rojkov commented Jul 6, 2017

core-image-ros-world builds successfully for me too with

Build Configuration:
BB_VERSION        = "1.34.0"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "fedora-25"
TARGET_SYS        = "i586-oe-linux"
MACHINE           = "qemux86"
DISTRO            = "nodistro"
DISTRO_VERSION    = "nodistro.0"
TUNE_FEATURES     = "m32 i586"
TARGET_FPU        = ""
meta              = "master:de7914954571ea8e717f56b6d6df13157b0973bc"
meta-oe           
meta-python       
meta-multimedia   = "master:66b88f7729d24ef2e3469fcaca172f420c4d54be"
meta-ros          = "bulwahn-resolve-issue-497-v1:9d6db38f0d38822b2e89af931038f5f4cce9a470"

and

Build Configuration:
BB_VERSION        = "1.34.0"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "fedora-25"
TARGET_SYS        = "x86_64-oe-linux"
MACHINE           = "qemux86-64"
DISTRO            = "nodistro"
DISTRO_VERSION    = "nodistro.0"
TUNE_FEATURES     = "m64 core2"
TARGET_FPU        = ""
meta              = "master:de7914954571ea8e717f56b6d6df13157b0973bc"
meta-oe           
meta-python       
meta-multimedia   = "master:66b88f7729d24ef2e3469fcaca172f420c4d54be"
meta-ros          = "bulwahn-resolve-issue-497-v1:9d6db38f0d38822b2e89af931038f5f4cce9a470"

@rojkov rojkov merged commit 2b77049 into ros:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants