ReadyToTest action timeout using decorator #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deepanshu <[email protected]>
Signed-off-by: deepanshu <[email protected]>
Signed-off-by: deepanshu <[email protected]>
Signed-off-by: deepanshu <[email protected]>
Signed-off-by: deepanshu <[email protected]>
Signed-off-by: deepanshu <[email protected]>
Signed-off-by: deepanshu <[email protected]>
ivanpauno
reviewed
Jul 8, 2022
launch_testing/test/launch_testing/test_ready_to_test_action_decorator.py
Outdated
Show resolved
Hide resolved
launch_testing/test/launch_testing/examples/ready_to_test_action_timeout_test.py
Outdated
Show resolved
Hide resolved
Signed-off-by: deepanshu <[email protected]>
Thanks a lot for the review, can I merge this now or wait for some more reviewers? |
|
You can merge with one approval. |
Signed-off-by: Aditya <[email protected]>
|
CI :
|
Signed-off-by: Aditya <[email protected]>
|
CI round 2 :
|
delete-merged-branch
bot
deleted the
deepanshu/ready-to-test-action-timeout
branch
|
I need this on humble, any reason not to backport? I could cherrypick it with no conflicts |
tonynajjar
pushed a commit
to angsa-robotics/launch
that referenced
this pull request
Apr 2, 2024
* Added support for configurable timeout duration for ReadyToTest action using decorator Signed-off-by: deepanshu <[email protected]> Co-authored-by: Aditya <[email protected]>
ping @deepanshubansal01, we'd also use this on humble. any chance for backporting it? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #582
By default the
ReadyToTestaction waits for 15 sec for the processes to start up, which means the processes that takes longer to start up, won't be able to start up. This PR adds a configurable timeout duration forReadyToTestaction by supporting a new decorator namelyready_to_test_action_timeoutSome discussion here #622
Signed-off-by: deepanshu [email protected]