-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Humble] Add topics with zero message counts to the SQLiteStorage::get_metadata(). #1722
[Humble] Add topics with zero message counts to the SQLiteStorage::get_metadata(). #1722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelOrlov i am trying to address for rolling
with #1725.
can i borrow your code for testing? i am not sure if this works for rolling
... any suggestions?
@fujitatomoya Sure, feel free to take any parts for rolling. The test should work for rolling as well; however, it will be better to parametrize it to run it for the |
cf510b9
to
3000974
Compare
@fujitatomoya I've updated |
rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with green CI.
@MichaelOrlov thanks for the note. btw, this is also gonna go to iron
after this humble fix, right? because #1725 only addressed rolling and jazzy.
@fujitatomoya Thanks for the review. We can propagate either this PR to the Iron or #1725. Need to double-check the base sources on Iron to see which one is better fit. |
Pulls: #1722 |
The RHEL9 build fails with error message
@clalancette Do you have any idea what RHEL complaining about? |
4bfbd95
to
0b1dd21
Compare
@clalancette I've fixed the RHEL build. I would appreciate if you would approve this backporting PR additionally so I can merge it. |
So unfortunately, that succeeding build on Humble is for RHEL-9, not RHEL-8 (which is what Humble supports). I think you should re-run the job on RHEL-8, and see what happens. |
Signed-off-by: Michael Orlov <[email protected]>
- Parametrize get_metadata_include_topics_with_zero_messages test to run for mcap and sqlite3 storage plugins. Signed-off-by: Michael Orlov <[email protected]>
- Include <algorithm> header and explicitly use reference on topic_metadata in a lambda capture list. Signed-off-by: Michael Orlov <[email protected]>
Signed-off-by: Michael Orlov <[email protected]>
0b1dd21
to
3f88538
Compare
The warning message
is unrelated to the changes in this PR. Re-run CI for RHEL8 after the rebase and suppressing PEP8:E402 warning |
@clalancette Ok. Now the RHEL8 CI job is green. Ready to be approved. |
either @clalancette or @MichaelOrlov can you create the backport PR by mergifyio? (i do not have permission on this repo) |
I'm not sure what you mean; this one was the backport PR, no? |
@clalancette sorry for the complication,
i have consulted with @MichaelOrlov before, because of the base code difference, we did take the different pathes to |
@Mergifyio backport iron |
✅ Backports have been created
|
…t_metadata(). (#1722) (cherry picked from commit 5da1796) # Conflicts: # rosbag2_py/test/test_convert.py # rosbag2_storage_sqlite3/src/rosbag2_storage_sqlite3/sqlite_storage.cpp Signed-off-by: Michael Orlov <[email protected]>
…metadata(). (backport #1722) (#1766) * [Humble] Add topics with zero message counts to the SQLiteStorage::get_metadata(). (#1722) (cherry picked from commit 5da1796) # Conflicts: # rosbag2_py/test/test_convert.py # rosbag2_storage_sqlite3/src/rosbag2_storage_sqlite3/sqlite_storage.cpp Signed-off-by: Michael Orlov <[email protected]> * Address merge conflicts Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Michael Orlov <[email protected]> Co-authored-by: Michael Orlov <[email protected]>
Have to do manual backporting because the code base is very different on humble branch in the affected places.