[jazzy] Add topics with zero message counts to the SQLiteStorage::get_metadata(). (backport #1725) #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…a(). (#1725) * storage_sqlite3 constructs metadata with topics don't have any messages. Signed-off-by: Tomoya Fujita <[email protected]> * Revert "storage_sqlite3 constructs metadata with topics don't have any messages." This reverts commit a842689. Signed-off-by: Tomoya Fujita <[email protected]> * update metadata list topics that does not have any messages. Signed-off-by: Tomoya Fujita <[email protected]> * add get_metadata_include_topics_with_zero_messages test Signed-off-by: Tomoya Fujita <[email protected]> Co-authored-by: Michael Orlov <[email protected]> * add std_msgs to rosbag2_cpp for test build. Signed-off-by: Tomoya Fujita <[email protected]> * call get_or_generate_extern_topic_id when updating metadata. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Co-authored-by: Michael Orlov <[email protected]> (cherry picked from commit ff829e8)
mergify
bot
requested review from
MichaelOrlov and
jhdcs
and removed request for
a team
MichaelOrlov
changed the title
MichaelOrlov
approved these changes
Jun 26, 2024
|
Pulls: #1731
|
fujitatomoya
approved these changes
Jun 26, 2024
|
https://github.com/Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Aug 9, 2024
…a(). (#1725) (#1731) * storage_sqlite3 constructs metadata with topics don't have any messages. Signed-off-by: Tomoya Fujita <[email protected]> * Revert "storage_sqlite3 constructs metadata with topics don't have any messages." This reverts commit a842689. Signed-off-by: Tomoya Fujita <[email protected]> * update metadata list topics that does not have any messages. Signed-off-by: Tomoya Fujita <[email protected]> * add get_metadata_include_topics_with_zero_messages test Signed-off-by: Tomoya Fujita <[email protected]> Co-authored-by: Michael Orlov <[email protected]> * add std_msgs to rosbag2_cpp for test build. Signed-off-by: Tomoya Fujita <[email protected]> * call get_or_generate_extern_topic_id when updating metadata. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> Co-authored-by: Michael Orlov <[email protected]> (cherry picked from commit ff829e8) Co-authored-by: Tomoya Fujita <[email protected]> (cherry picked from commit 2a627c9) # Conflicts: # rosbag2_cpp/CMakeLists.txt # rosbag2_storage_sqlite3/src/rosbag2_storage_sqlite3/sqlite_storage.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rolling.I guess we can backport this to
jazzy.This is an automatic backport of pull request Add topics with zero message counts to the SQLiteStorage::get_metadata(). #1725 done by Mergify.