`dnf history` operations that work with comps correctly #1689

dmach · 2020-11-23T13:06:23Z

Tests: rpm-software-management/ci-dnf-stack#916

pep8speaks · 2020-11-23T13:06:28Z

Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file dnf/transaction_sr.py:

Line 66:121: E501 line too long (136 > 120 characters)
Line 231:5: E303 too many blank lines (2)

Comment last updated at 2021-01-07 10:03:46 UTC

lgtm-com · 2020-11-23T13:17:38Z

This pull request introduces 4 alerts and fixes 3 when merging 5e414e1 into e5b25b8 - view on LGTM.com

new alerts:

2 for Except block handles 'BaseException'
2 for Unused import

fixed alerts:

3 for Unreachable code

lgtm-com · 2020-11-24T12:40:00Z

This pull request introduces 2 alerts and fixes 3 when merging 12f9677 into e5b25b8 - view on LGTM.com

new alerts:

2 for Unused import

fixed alerts:

3 for Unreachable code

lgtm-com · 2020-11-24T13:13:43Z

This pull request introduces 2 alerts and fixes 3 when merging 733bcc4 into e5b25b8 - view on LGTM.com

new alerts:

2 for Unused import

fixed alerts:

3 for Unreachable code

dnf/transaction_sr.py

dnf/cli/commands/history.py

dnf/transaction_sr.py

lukash · 2020-11-30T16:20:36Z

dnf/transaction_sr.py

@@ -220,25 +219,31 @@ def __init__(
        self._nevra_reason_cache = {}
        self._warnings = []

+    def load_from_file(self, fn):


I'm not sure whether it's a better API to have load_from_file() and load_from_dict() methods aor whether it would be better to have an init like __init__(self, base, data=None, filename=None, ...) and then you'd specify one of [data, filename] when instantiating the class? I know there's no RAII in Python 🙂 but the class now requires you to call a load method and if you don't, you'll get a rather unspecific crash (though it's a programmer error).

dnf/transaction_sr.py

lgtm-com · 2020-12-03T15:25:54Z

This pull request introduces 4 alerts and fixes 3 when merging b7f4a62 into d8c71d2 - view on LGTM.com

new alerts:

2 for Unused import
1 for Missing call to __init__ during object initialization
1 for First argument to super() is not enclosing class

fixed alerts:

3 for Unreachable code

lukash

Thanks for restructuring the commits! I still think the code needs to be adjusted for the new usage, particularly the error handling part. I'm not too proud of the errors/warnings code myself and this makes it even more cumbersome, I think it still deserves some work.

dnf/cli/commands/history.py

dnf/transaction_sr.py

packit-as-a-service · 2020-12-10T14:07:58Z

Congratulations! One of the builds has completed. 🍾

⚠️ Please note that our current plans include removal of these comments in the near future (at least 2 weeks after including this disclaimer), if you have serious concerns regarding their removal or would like to continue receiving them please reach out to us. ⚠️

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/rpm-software-management-dnf-1689
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

lgtm-com · 2020-12-10T14:10:53Z

This pull request introduces 2 alerts and fixes 3 when merging 73575e5 into b73d813 - view on LGTM.com

new alerts:

2 for Unused import

fixed alerts:

3 for Unreachable code

lgtm-com · 2020-12-17T10:17:23Z

This pull request introduces 8 alerts and fixes 3 when merging fcdef43 into 11ce84b - view on LGTM.com

new alerts:

6 for Unused local variable
2 for Unused import

fixed alerts:

3 for Unreachable code

lukash · 2020-12-17T14:10:29Z

dnf/transaction_sr.py

    ):
        """
        :param base: the dnf base
        :param fn: the filename to load the transaction from
        :param ignore_extras: whether to ignore extra package pulled into the transaction
        :param ignore_installed: whether to ignore installed versions of packages
        :param skip_unavailable: whether to skip transaction packages that aren't available
+        :param history_mode: enable a more permissive behavior for `dnf history {undo|redo|rollback}` commands


This looks a bit like a rudimentary brace. The description of the new argument doesn't say anything about its effect, just refers to it being related to history. On this level the switch should be based on its semantics and not on it's usage. The logic around this is again already non-trivial and this muddies up the waters even more.

dnf/transaction_sr.py

dnf/cli/commands/history.py

lgtm-com · 2020-12-17T16:07:10Z

This pull request introduces 8 alerts and fixes 3 when merging 32720cc into 11ce84b - view on LGTM.com

new alerts:

6 for Unused local variable
2 for Unused import

fixed alerts:

3 for Unreachable code

lgtm-com · 2021-01-06T09:36:54Z

This pull request introduces 8 alerts and fixes 3 when merging dc4bedd into 11ce84b - view on LGTM.com

new alerts:

6 for Unused local variable
2 for Unused import

fixed alerts:

3 for Unreachable code

lukash · 2021-01-06T10:43:26Z

dnf/transaction_sr.py

@@ -187,14 +187,16 @@ class TransactionReplay(object):
    def __init__(
        self,
        base,
-        fn,
+        fn="",


Can you please just name the argument filename instead of fn? It's a bit more important since it's now mutually exclusive with the data and they both should be self-descriptive, not abbreviated. Otherwise looks good.

Changed. I hope it did not break anything and the tests will pass.

= changelog = msg: Support comps groups in history redo type: enhancement resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1657123 resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1809565 resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1809639

= changelog = msg: Support comps groups in history rollback type: enhancement resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1657123 resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1809565 resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1809639

= changelog = msg: Support comps groups in history undo type: enhancement resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1657123 resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1809565 resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1809639

…ction_sr code

When _ignore_installed == True, then an exception is raised anyway. When _ignore_installed == False, get the requested package to the system regardless the action.

lgtm-com · 2021-01-07T10:09:46Z

This pull request introduces 8 alerts and fixes 3 when merging 49d8837 into 11ce84b - view on LGTM.com

new alerts:

6 for Unused local variable
2 for Unused import

fixed alerts:

3 for Unreachable code

dmach added the work in progress label Nov 23, 2020

dmach force-pushed the history-comps branch from 5e414e1 to 12f9677 Compare November 24, 2020 12:29

dmach force-pushed the history-comps branch from 12f9677 to 733bcc4 Compare November 24, 2020 13:07

dmach mentioned this pull request Nov 24, 2020

Test history operations with comps rpm-software-management/ci-dnf-stack#916

Merged

dmach added ready for review and removed work in progress labels Nov 24, 2020

lukash self-assigned this Nov 25, 2020

lukash reviewed Nov 30, 2020

View reviewed changes

dmach force-pushed the history-comps branch from 733bcc4 to b7f4a62 Compare December 3, 2020 15:19

dmach mentioned this pull request Dec 8, 2020

[history] rollback/remove/undo for groups and envs #1445

Closed

lukash reviewed Dec 9, 2020

View reviewed changes

dmach force-pushed the history-comps branch from b7f4a62 to 73575e5 Compare December 10, 2020 14:03

dmach force-pushed the history-comps branch from 73575e5 to fcdef43 Compare December 17, 2020 10:11

lukash reviewed Dec 17, 2020

View reviewed changes

dmach force-pushed the history-comps branch from fcdef43 to 32720cc Compare December 17, 2020 16:00

dmach force-pushed the history-comps branch from 32720cc to dc4bedd Compare January 6, 2021 09:28

lukash reviewed Jan 6, 2021

View reviewed changes

Daniel Mach added 3 commits January 7, 2021 11:02

transaction_sr: Enable loading transactions from dict

1757cef

transaction_sr: Store exception attributes for future use

a8e422b

transaction_sr: Handle serialize_transaction(None)

acdd0c4

Daniel Mach added 9 commits January 7, 2021 11:02

transaction_sr: Skip preferred repo lookup if repoid is empty

a944d76

Remove Base._history_undo_operations() as it was replaced with transa…

a07f6e4

…ction_sr code

history: Move history methods from BaseCli to HistoryCommand

c8c4400

transaction_sr: Simplify error reporting, unify with history

316e1e6

transaction_sr: TransactionFileError exception to TransactionReplayError

8ff41ce

transaction_sr: Don't return if there's a mismatch in actions

49d8837

When _ignore_installed == True, then an exception is raised anyway. When _ignore_installed == False, get the requested package to the system regardless the action.

dmach force-pushed the history-comps branch from dc4bedd to 49d8837 Compare January 7, 2021 10:03

lukash merged commit 6697f09 into rpm-software-management:master Jan 7, 2021

This was referenced Jan 30, 2024

Fix history rollback command does not meet the expected result #2042

Closed

Unexpected results in 'dnf history rollback' #2031

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`dnf history` operations that work with comps correctly #1689

`dnf history` operations that work with comps correctly #1689

dmach commented Nov 23, 2020 •

edited

Loading

pep8speaks commented Nov 23, 2020 •

edited

Loading

lgtm-com bot commented Nov 23, 2020

lgtm-com bot commented Nov 24, 2020

lgtm-com bot commented Nov 24, 2020

lukash Nov 30, 2020

lgtm-com bot commented Dec 3, 2020

lukash left a comment

packit-as-a-service bot commented Dec 10, 2020

lgtm-com bot commented Dec 10, 2020

lgtm-com bot commented Dec 17, 2020

lukash Dec 17, 2020

lgtm-com bot commented Dec 17, 2020

lgtm-com bot commented Jan 6, 2021

lukash Jan 6, 2021

dmach Jan 7, 2021

lgtm-com bot commented Jan 7, 2021

dnf history operations that work with comps correctly #1689

dnf history operations that work with comps correctly #1689

Conversation

dmach commented Nov 23, 2020 • edited Loading

pep8speaks commented Nov 23, 2020 • edited Loading

Comment last updated at 2021-01-07 10:03:46 UTC

lgtm-com bot commented Nov 23, 2020

lgtm-com bot commented Nov 24, 2020

lgtm-com bot commented Nov 24, 2020

lukash Nov 30, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Dec 3, 2020

lukash left a comment

Choose a reason for hiding this comment

packit-as-a-service bot commented Dec 10, 2020

lgtm-com bot commented Dec 10, 2020

lgtm-com bot commented Dec 17, 2020

lukash Dec 17, 2020

Choose a reason for hiding this comment

lgtm-com bot commented Dec 17, 2020

lgtm-com bot commented Jan 6, 2021

lukash Jan 6, 2021

Choose a reason for hiding this comment

dmach Jan 7, 2021

Choose a reason for hiding this comment

lgtm-com bot commented Jan 7, 2021

`dnf history` operations that work with comps correctly #1689

`dnf history` operations that work with comps correctly #1689

dmach commented Nov 23, 2020 •

edited

Loading

pep8speaks commented Nov 23, 2020 •

edited

Loading